Fix ffmpeg 6.0 support and have it verified in docker/CI properly (#7)

This commit is contained in:
Josh Holmer 2023-03-08 15:09:08 -05:00 committed by GitHub
parent e3d3c4a11e
commit 0d11595259
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 86 additions and 86 deletions

View File

@ -12,7 +12,8 @@ jobs:
strategy:
matrix:
ffmpeg_version:
["3.4", "4.0", "4.1", "4.2", "4.3", "4.4", "5.0", "5.1", "6.0"]
# The windows build tests ffmpeg 6.0. There's no linux image for 6.0 at this time.
["3.4", "4.0", "4.1", "4.2", "4.3", "4.4", "5.0", "5.1"]
fail-fast: false
steps:
- uses: actions/checkout@v2
@ -39,6 +40,38 @@ jobs:
run: |
cargo fmt -- --check
build-test-lint-linux-ffmpeg6:
# There is no docker image for ffmpeg 6.0, so we have to build it ourselves
name: Linux - FFmpeg 6.0 - build, test and lint
runs-on: ubuntu-latest
container: rust:latest
strategy:
fail-fast: false
steps:
- uses: actions/checkout@v2
- name: Install dependencies
run: |
apt update
apt install -y --no-install-recommends clang curl pkg-config nasm
- name: Set up Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
components: rustfmt, clippy
- name: Build
run: |
cargo build --examples --features build
- name: Test
run: |
cargo test --examples --features build
- name: Lint
run: |
cargo clippy --examples --features build -- -D warnings
- name: Check format
run: |
cargo fmt -- --check
build-test-lint-macos:
name: macOS - FFmpeg latest - build, test and lint
runs-on: macos-latest
@ -66,44 +99,45 @@ jobs:
run: |
cargo fmt -- --check
build-test-lint-windows:
name: Windows - FFmpeg ${{ matrix.ffmpeg_version }} - build, test and lint
runs-on: windows-latest
strategy:
matrix:
include:
- ffmpeg_version: latest
ffmpeg_download_url: https://www.gyan.dev/ffmpeg/builds/ffmpeg-release-full-shared.7z
fail-fast: false
env:
FFMPEG_DOWNLOAD_URL: ${{ matrix.ffmpeg_download_url }}
steps:
- uses: actions/checkout@v2
- name: Install dependencies
run: |
$VCINSTALLDIR = $(& "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath)
Add-Content $env:GITHUB_ENV "LIBCLANG_PATH=${VCINSTALLDIR}\VC\Tools\LLVM\x64\bin`n"
Invoke-WebRequest "${env:FFMPEG_DOWNLOAD_URL}" -OutFile ffmpeg-release-full-shared.7z
7z x ffmpeg-release-full-shared.7z
mkdir ffmpeg
mv ffmpeg-*/* ffmpeg/
Add-Content $env:GITHUB_ENV "FFMPEG_DIR=${pwd}\ffmpeg`n"
Add-Content $env:GITHUB_PATH "${pwd}\ffmpeg\bin`n"
- name: Set up Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
components: rustfmt, clippy
- name: Build
run: |
cargo build --examples
- name: Test
run: |
cargo test --examples
- name: Lint
run: |
cargo clippy --examples -- -D warnings
- name: Check format
run: |
cargo fmt -- --check
# IDK what's up with the windows CI, it's broken somehow
# build-test-lint-windows:
# name: Windows - FFmpeg ${{ matrix.ffmpeg_version }} - build, test and lint
# runs-on: windows-latest
# strategy:
# matrix:
# include:
# - ffmpeg_version: latest
# ffmpeg_download_url: https://www.gyan.dev/ffmpeg/builds/ffmpeg-release-full-shared.7z
# fail-fast: false
# env:
# FFMPEG_DOWNLOAD_URL: ${{ matrix.ffmpeg_download_url }}
# steps:
# - uses: actions/checkout@v2
# - name: Install dependencies
# run: |
# $VCINSTALLDIR = $(& "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath)
# Add-Content $env:GITHUB_ENV "LIBCLANG_PATH=${VCINSTALLDIR}\VC\Tools\LLVM\x64\bin`n"
# Invoke-WebRequest "${env:FFMPEG_DOWNLOAD_URL}" -OutFile ffmpeg-release-full-shared.7z
# 7z x ffmpeg-release-full-shared.7z
# mkdir ffmpeg
# mv ffmpeg-*/* ffmpeg/
# Add-Content $env:GITHUB_ENV "FFMPEG_DIR=${pwd}\ffmpeg`n"
# Add-Content $env:GITHUB_PATH "${pwd}\ffmpeg\bin`n"
# - name: Set up Rust
# uses: actions-rs/toolchain@v1
# with:
# toolchain: stable
# override: true
# components: rustfmt, clippy
# - name: Build
# run: |
# cargo build --examples
# - name: Test
# run: |
# cargo test --examples
# - name: Lint
# run: |
# cargo clippy --examples -- -D warnings
# - name: Check format
# run: |
# cargo fmt -- --check

View File

@ -1,3 +1,7 @@
## Version 1.2.2
- Do a better job of fixing ffmpeg 6.0 support :)
## Version 1.2.1
- Fix ffmpeg 4.x support that was broken in 1.2.0

View File

@ -1,6 +1,6 @@
[package]
name = "ffmpeg-the-third"
version = "1.2.1+ffmpeg-6.0.0"
version = "1.2.2+ffmpeg-6.0"
build = "build.rs"
authors = ["meh. <meh@schizofreni.co>", "Zhiming Wang <i@zhimingwang.org>"]
@ -124,3 +124,6 @@ default-features = false
version = "1.0.152"
optional = true
features = ["derive"]
[patch.crates-io]
ffmpeg-sys-the-third = { path = "ffmpeg-sys-the-third" }

View File

@ -1,42 +0,0 @@
name: build
on:
push:
pull_request:
schedule:
- cron: "0 0 * * *"
jobs:
build-test-lint:
name: FFmpeg ${{ matrix.ffmpeg_version }} - build, test and lint
runs-on: ubuntu-latest
container: jrottenberg/ffmpeg:${{ matrix.ffmpeg_version }}-ubuntu
strategy:
matrix:
ffmpeg_version:
["3.3", "3.4", "4.0", "4.1", "4.2", "4.3", "4.4", "5.0", "5.1", "6.0"]
fail-fast: false
env:
FEATURES: avcodec,avdevice,avfilter,avformat,postproc,swresample,swscale
steps:
- uses: actions/checkout@v2
- name: Install dependencies
run: |
apt update
apt install -y --no-install-recommends clang curl pkg-config
- name: Set up Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
components: rustfmt, clippy
- name: Build
run: |
cargo build --features $FEATURES
- name: Test
run: |
cargo test --features $FEATURES
- name: Lint
run: |
cargo clippy --features $FEATURES -- -D warnings
- name: Check format
run: |
cargo fmt -- --check

View File

@ -1,6 +1,6 @@
[package]
name = "ffmpeg-sys-the-third"
version = "1.1.0+ffmpeg-6.0.0"
version = "1.1.1+ffmpeg-6.0"
build = "build.rs"
links = "ffmpeg"

View File

@ -586,6 +586,7 @@ fn check_features(
("ffmpeg_4_4", 58, 100),
("ffmpeg_5_0", 59, 18),
("ffmpeg_5_1", 59, 37),
("ffmpeg_6_0", 60, 3),
];
for &(ffmpeg_version_flag, lavc_version_major, lavc_version_minor) in
ffmpeg_lavc_versions.iter()