Kieran/ffmpeg-the-third
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

*: returning &mut Self from setters was an awful idea

Browse Source 
Deref breaks things.
This commit is contained in:
meh
2015-10-04 03:21:52 +02:00
parent 0764c597e4
commit 132c514e3f
16 changed files with 151 additions and 279 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/codec/encoder/audio.rs
View File

@ -54,12 +54,10 @@ impl Audio {
}
}
pub fn set_rate(&mut self, rate: i32) -> &mut Self {
pub fn set_rate(&mut self, rate: i32) {
unsafe {
(*self.as_mut_ptr()).sample_rate = rate;
}
self
}
pub fn rate(&self) -> u32 {
@ -68,12 +66,10 @@ impl Audio {
}
}
pub fn set_format(&mut self, value: format::Sample) -> &mut Self {
pub fn set_format(&mut self, value: format::Sample) {
unsafe {
(*self.as_mut_ptr()).sample_fmt = value.into();
}
self
}
pub fn format(&self) -> format::Sample {
@ -82,12 +78,10 @@ impl Audio {
}
}
pub fn set_channel_layout(&mut self, value: ChannelLayout) -> &mut Self {
pub fn set_channel_layout(&mut self, value: ChannelLayout) {
unsafe {
(*self.as_mut_ptr()).channel_layout = value.bits();
}
self
}
pub fn channel_layout(&self) -> ChannelLayout {
@ -96,12 +90,10 @@ impl Audio {
}
}
pub fn set_channels(&mut self, value: i32) -> &mut Self {
pub fn set_channels(&mut self, value: i32) {
unsafe {
(*self.as_mut_ptr()).channels = value;
}
self
}
pub fn channels(&self) -> u16 {