From 2a2c713486336f64c6217a09ebaa995353dba0b3 Mon Sep 17 00:00:00 2001
From: Martti Malmi <sirius@iki.fi>
Date: Thu, 4 Jan 2024 11:54:58 +0200
Subject: [PATCH] eslint: react-refresh, react-hooks

---
 packages/app/.eslintrc.cjs                    | 11 ++++++++--
 packages/app/package.json                     |  2 ++
 .../app/src/Element/Button/AsyncButton.tsx    |  2 ++
 .../app/src/Element/Embed/ZapstrEmbed.tsx     |  2 +-
 .../src/Element/Event/Create/NoteCreator.tsx  |  6 +++---
 packages/app/src/Element/Event/FileUpload.tsx |  2 +-
 packages/app/src/Element/Event/Thread.tsx     |  7 ++++---
 .../app/src/Element/Feed/TimelineRenderer.tsx |  3 ++-
 packages/app/src/Element/ReBroadcaster.tsx    |  2 +-
 packages/app/src/Element/SendSats.tsx         |  1 +
 packages/app/src/Pages/HashTagsPage.tsx       |  2 +-
 packages/app/src/Pages/ZapPool.tsx            |  6 +++---
 packages/app/src/Pages/onboarding/index.tsx   |  2 +-
 packages/app/src/Pages/settings/Keys.tsx      |  2 +-
 .../app/src/Pages/settings/Moderation.tsx     |  2 +-
 .../app/src/Pages/settings/Preferences.tsx    |  2 +-
 packages/app/src/Pages/settings/RelayInfo.tsx |  2 +-
 packages/app/src/Pages/settings/Relays.tsx    |  2 +-
 .../settings/tools/follows-relay-health.tsx   |  3 ++-
 .../Pages/settings/tools/prune-follows.tsx    |  2 +-
 packages/app/src/Pages/subscribe/index.tsx    |  6 +++---
 yarn.lock                                     | 20 +++++++++++++++++++
 22 files changed, 62 insertions(+), 27 deletions(-)

diff --git a/packages/app/.eslintrc.cjs b/packages/app/.eslintrc.cjs
index 393729b6..46f61f4c 100644
--- a/packages/app/.eslintrc.cjs
+++ b/packages/app/.eslintrc.cjs
@@ -1,7 +1,12 @@
 module.exports = {
-  extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended", "plugin:react/recommended"],
+  extends: [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+  ],
   parser: "@typescript-eslint/parser",
-  plugins: ["@typescript-eslint", "formatjs"],
+  plugins: ["@typescript-eslint", "formatjs", "react-refresh"],
   rules: {
     "formatjs/enforce-id": [
       "error",
@@ -10,6 +15,8 @@ module.exports = {
       },
     ],
     "react/react-in-jsx-scope": "off",
+    "react-hooks/exhaustive-deps": "off",
+    "react-refresh/only-export-components": "warn",
   },
   root: true,
   ignorePatterns: ["build/", "*.test.ts", "*.js"],
diff --git a/packages/app/package.json b/packages/app/package.json
index a3b92b9f..493e94c8 100644
--- a/packages/app/package.json
+++ b/packages/app/package.json
@@ -100,6 +100,8 @@
     "eslint": "^8.48.0",
     "eslint-plugin-formatjs": "^4.11.3",
     "eslint-plugin-react": "^7.33.2",
+    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-react-refresh": "^0.4.5",
     "postcss": "^8.4.31",
     "postcss-preset-env": "^9.2.0",
     "prettier": "2.8.3",
diff --git a/packages/app/src/Element/Button/AsyncButton.tsx b/packages/app/src/Element/Button/AsyncButton.tsx
index 1876b10b..3365b8c0 100644
--- a/packages/app/src/Element/Button/AsyncButton.tsx
+++ b/packages/app/src/Element/Button/AsyncButton.tsx
@@ -29,4 +29,6 @@ const AsyncButton = React.forwardRef<HTMLButtonElement, AsyncButtonProps>((props
   );
 });
 
+AsyncButton.displayName = "AsyncButton";
+
 export default AsyncButton;
diff --git a/packages/app/src/Element/Embed/ZapstrEmbed.tsx b/packages/app/src/Element/Embed/ZapstrEmbed.tsx
index 648f31b2..a213c93f 100644
--- a/packages/app/src/Element/Embed/ZapstrEmbed.tsx
+++ b/packages/app/src/Element/Embed/ZapstrEmbed.tsx
@@ -24,7 +24,7 @@ export default function ZapstrEmbed({ ev }: { ev: NostrEvent }) {
           <audio src={media?.[1] ?? ""} controls={true} />
           <div>
             {refPersons.map(a => (
-              <ProfileImage pubkey={a[1]} subHeader={<>{a[2] ?? ""}</>} className="" defaultNip=" " />
+              <ProfileImage key={a[1]} pubkey={a[1]} subHeader={<>{a[2] ?? ""}</>} className="" defaultNip=" " />
             ))}
           </div>
         </div>
diff --git a/packages/app/src/Element/Event/Create/NoteCreator.tsx b/packages/app/src/Element/Event/Create/NoteCreator.tsx
index c116832e..eb610206 100644
--- a/packages/app/src/Element/Event/Create/NoteCreator.tsx
+++ b/packages/app/src/Element/Event/Create/NoteCreator.tsx
@@ -345,7 +345,7 @@ export function NoteCreator() {
         {Object.keys(relays.item || {})
           .filter(el => relays.item[el].write)
           .map((r, i, a) => (
-            <div className="p flex justify-between note-creator-relay">
+            <div className="p flex justify-between note-creator-relay" key={r}>
               <div>{r}</div>
               <div>
                 <input
@@ -406,8 +406,8 @@ export function NoteCreator() {
           </h4>
           <FormattedMessage defaultMessage="Zaps on this note will be split to the following users." id="LwYmVi" />
           <div className="flex flex-col g8">
-            {[...(note.zapSplits ?? [])].map((v, i, arr) => (
-              <div className="flex items-center g8">
+            {[...(note.zapSplits ?? [])].map((v: ZapTarget, i, arr) => (
+              <div className="flex items-center g8" key={`${v.name}-${v.value}`}>
                 <div className="flex flex-col flex-4 g4">
                   <h4>
                     <FormattedMessage defaultMessage="Recipient" id="8Rkoyb" />
diff --git a/packages/app/src/Element/Event/FileUpload.tsx b/packages/app/src/Element/Event/FileUpload.tsx
index 0fb7c4c1..4b5f7dd2 100644
--- a/packages/app/src/Element/Event/FileUpload.tsx
+++ b/packages/app/src/Element/Event/FileUpload.tsx
@@ -5,7 +5,7 @@ export default function FileUploadProgress({ progress }: { progress: Array<Uploa
   return (
     <div className="flex flex-col g8">
       {progress.map(p => (
-        <div className="flex flex-col g2" id={p.id}>
+        <div key={p.id} className="flex flex-col g2" id={p.id}>
           {p.file.name}
           <Progress value={p.progress} status={p.stage} />
         </div>
diff --git a/packages/app/src/Element/Event/Thread.tsx b/packages/app/src/Element/Event/Thread.tsx
index c728a8d7..3d3eb796 100644
--- a/packages/app/src/Element/Event/Thread.tsx
+++ b/packages/app/src/Element/Event/Thread.tsx
@@ -1,5 +1,5 @@
 import "./Thread.css";
-import { useMemo, useState, ReactNode, useContext } from "react";
+import { useMemo, useState, ReactNode, useContext, Fragment } from "react";
 import { useIntl } from "react-intl";
 import { useNavigate, useParams } from "react-router-dom";
 import { TaggedNostrEvent, u256, NostrPrefix, EventExt, parseNostrLink, NostrLink } from "@snort/system";
@@ -41,7 +41,7 @@ const Subthread = ({ active, notes, related, chains, onNavigate }: SubthreadProp
     const isLastSubthread = idx === notes.length - 1;
     const replies = getReplies(a.id, chains);
     return (
-      <>
+      <Fragment key={a.id}>
         <div className={`subthread-container ${replies.length > 0 ? "subthread-multi" : ""}`}>
           <Divider />
           <Note
@@ -65,7 +65,7 @@ const Subthread = ({ active, notes, related, chains, onNavigate }: SubthreadProp
             onNavigate={onNavigate}
           />
         )}
-      </>
+      </Fragment>
     );
   };
 
@@ -138,6 +138,7 @@ const TierTwo = ({ active, isLastSubthread, notes, related, chains, onNavigate }
         const lastReply = idx === rest.length - 1;
         return (
           <ThreadNote
+            key={r.id}
             active={active}
             onNavigate={onNavigate}
             note={r}
diff --git a/packages/app/src/Element/Feed/TimelineRenderer.tsx b/packages/app/src/Element/Feed/TimelineRenderer.tsx
index 67c32e7c..0f9e3655 100644
--- a/packages/app/src/Element/Feed/TimelineRenderer.tsx
+++ b/packages/app/src/Element/Feed/TimelineRenderer.tsx
@@ -111,7 +111,7 @@ export function TimelineRenderer(props: TimelineRendererProps) {
         <>
           <div className="card latest-notes" onClick={() => props.showLatest(false)} ref={ref}>
             {props.latest.slice(0, 3).map(p => {
-              return <ProfileImage pubkey={p} showUsername={false} link={""} showFollowDistance={false} />;
+              return <ProfileImage key={p} pubkey={p} showUsername={false} link={""} showFollowDistance={false} />;
             })}
             <FormattedMessage
               defaultMessage="{n} new {n, plural, =1 {note} other {notes}}"
@@ -128,6 +128,7 @@ export function TimelineRenderer(props: TimelineRendererProps) {
               {props.latest.slice(0, 3).map(p => {
                 return (
                   <ProfileImage
+                    key={p}
                     pubkey={p}
                     showProfileCard={false}
                     showUsername={false}
diff --git a/packages/app/src/Element/ReBroadcaster.tsx b/packages/app/src/Element/ReBroadcaster.tsx
index 88dbe1d1..d6b0c63e 100644
--- a/packages/app/src/Element/ReBroadcaster.tsx
+++ b/packages/app/src/Element/ReBroadcaster.tsx
@@ -27,7 +27,7 @@ export function ReBroadcaster({ onClose, ev }: { onClose: () => void; ev: Tagged
         {Object.keys(relays.item || {})
           .filter(el => relays.item[el].write)
           .map((r, i, a) => (
-            <div className="card flex justify-between">
+            <div key={r} className="card flex justify-between">
               <div>{r}</div>
               <div>
                 <input
diff --git a/packages/app/src/Element/SendSats.tsx b/packages/app/src/Element/SendSats.tsx
index c19c4aae..7b7554a2 100644
--- a/packages/app/src/Element/SendSats.tsx
+++ b/packages/app/src/Element/SendSats.tsx
@@ -165,6 +165,7 @@ export default function SendSats(props: SendSatsProps) {
           <div className="flex g4 f-wrap">
             {props.targets.map(v => (
               <ProfileImage
+                key={v.value}
                 pubkey={v.value}
                 showUsername={false}
                 showFollowDistance={false}
diff --git a/packages/app/src/Pages/HashTagsPage.tsx b/packages/app/src/Pages/HashTagsPage.tsx
index de3bd286..249a9e3a 100644
--- a/packages/app/src/Pages/HashTagsPage.tsx
+++ b/packages/app/src/Pages/HashTagsPage.tsx
@@ -93,7 +93,7 @@ export function HashTagHeader({ tag, events, className }: { tag: string; events?
       </div>
       <div className="flex items-center">
         {pubkeys.slice(0, 5).map(a => (
-          <ProfileImage pubkey={a} showUsername={false} showFollowDistance={false} size={40} />
+          <ProfileImage key={a} pubkey={a} showUsername={false} showFollowDistance={false} size={40} />
         ))}
         {pubkeys.length > 5 && (
           <span>
diff --git a/packages/app/src/Pages/ZapPool.tsx b/packages/app/src/Pages/ZapPool.tsx
index d52b3193..8e28996b 100644
--- a/packages/app/src/Pages/ZapPool.tsx
+++ b/packages/app/src/Pages/ZapPool.tsx
@@ -173,7 +173,7 @@ export default function ZapPoolPage() {
         <FormattedMessage defaultMessage="Relays" id="RoOyAh" />
       </h3>
       {relayConnections.map(a => (
-        <div>
+        <div key={a.address}>
           <h4>{getRelayName(a.address)}</h4>
           <ZapPoolTarget
             target={
@@ -191,7 +191,7 @@ export default function ZapPoolPage() {
         <FormattedMessage defaultMessage="File hosts" id="XICsE8" />
       </h3>
       {UploaderServices.map(a => (
-        <div>
+        <div key={a.name}>
           <h4>{a.name}</h4>
           <ZapPoolTarget
             target={
@@ -209,7 +209,7 @@ export default function ZapPoolPage() {
         <FormattedMessage defaultMessage="Data Providers" id="ELbg9p" />
       </h3>
       {DataProviders.map(a => (
-        <div>
+        <div key={a.name}>
           <h4>{a.name}</h4>
           <ZapPoolTarget
             target={
diff --git a/packages/app/src/Pages/onboarding/index.tsx b/packages/app/src/Pages/onboarding/index.tsx
index d51f6064..a7cbda4e 100644
--- a/packages/app/src/Pages/onboarding/index.tsx
+++ b/packages/app/src/Pages/onboarding/index.tsx
@@ -25,7 +25,7 @@ function OnboardingLayout() {
         <Icon name="translate" />
         <select value={lang} onChange={e => setOverride(e.target.value)} className="capitalize">
           {AllLanguageCodes.sort().map(a => (
-            <option value={a}>
+            <option key={a} value={a}>
               {new Intl.DisplayNames([a], {
                 type: "language",
               }).of(a)}
diff --git a/packages/app/src/Pages/settings/Keys.tsx b/packages/app/src/Pages/settings/Keys.tsx
index 2179c324..c246d30e 100644
--- a/packages/app/src/Pages/settings/Keys.tsx
+++ b/packages/app/src/Pages/settings/Keys.tsx
@@ -33,7 +33,7 @@ export default function ExportKeys() {
             {hexToMnemonic(generatedEntropy ?? "")
               .split(" ")
               .map((a, i) => (
-                <div className="flex items-center word">
+                <div key={a} className="flex items-center word">
                   <div>{i + 1}</div>
                   <div>{a}</div>
                 </div>
diff --git a/packages/app/src/Pages/settings/Moderation.tsx b/packages/app/src/Pages/settings/Moderation.tsx
index 1f88b20d..f3c852ca 100644
--- a/packages/app/src/Pages/settings/Moderation.tsx
+++ b/packages/app/src/Pages/settings/Moderation.tsx
@@ -80,7 +80,7 @@ export default function ModerationSettingsPage() {
           </button>
         </div>
         {appData.mutedWords.map(v => (
-          <div className="p br b flex items-center justify-between">
+          <div key={v} className="p br b flex items-center justify-between">
             <div>{v}</div>
             <button type="button" onClick={() => removeMutedWord(v)}>
               <FormattedMessage defaultMessage="Delete" id="K3r6DQ" />
diff --git a/packages/app/src/Pages/settings/Preferences.tsx b/packages/app/src/Pages/settings/Preferences.tsx
index f30ac428..236ab3ff 100644
--- a/packages/app/src/Pages/settings/Preferences.tsx
+++ b/packages/app/src/Pages/settings/Preferences.tsx
@@ -59,7 +59,7 @@ const PreferencesPage = () => {
             }
             style={{ textTransform: "capitalize" }}>
             {AllLanguageCodes.sort().map(a => (
-              <option value={a}>
+              <option key={a} value={a}>
                 {new Intl.DisplayNames([a], {
                   type: "language",
                 }).of(a)}
diff --git a/packages/app/src/Pages/settings/RelayInfo.tsx b/packages/app/src/Pages/settings/RelayInfo.tsx
index f9cea355..ef3b3eb5 100644
--- a/packages/app/src/Pages/settings/RelayInfo.tsx
+++ b/packages/app/src/Pages/settings/RelayInfo.tsx
@@ -75,7 +75,7 @@ const RelayInfo = () => {
             </h4>
             <div className="grow">
               {stats.info.supported_nips.map(a => (
-                <a target="_blank" rel="noreferrer" href={`https://nips.be/${a}`} className="pill">
+                <a key={a} target="_blank" rel="noreferrer" href={`https://nips.be/${a}`} className="pill">
                   NIP-{a.toString().padStart(2, "0")}
                 </a>
               ))}
diff --git a/packages/app/src/Pages/settings/Relays.tsx b/packages/app/src/Pages/settings/Relays.tsx
index eacfeec8..57493b57 100644
--- a/packages/app/src/Pages/settings/Relays.tsx
+++ b/packages/app/src/Pages/settings/Relays.tsx
@@ -148,7 +148,7 @@ export function CloseRelays() {
         ?.filter(a => !relayUrls.includes(unwrap(sanitizeRelayUrl(a.url))) && !a.is_paid)
         .sort((a, b) => (a.distance > b.distance ? 1 : -1))
         .map(a => (
-          <div className="bg-dark p br flex flex-col g8">
+          <div key={a.url} className="bg-dark p br flex flex-col g8">
             <div className="flex justify-between items-center">
               <div className="bold">{getRelayName(a.url)}</div>
               <AsyncButton
diff --git a/packages/app/src/Pages/settings/tools/follows-relay-health.tsx b/packages/app/src/Pages/settings/tools/follows-relay-health.tsx
index 19e4099e..4d046479 100644
--- a/packages/app/src/Pages/settings/tools/follows-relay-health.tsx
+++ b/packages/app/src/Pages/settings/tools/follows-relay-health.tsx
@@ -62,6 +62,7 @@ export function FollowsRelayHealth({
           <div>
             {missingRelays.map(a => (
               <ProfilePreview
+                key={a}
                 pubkey={a}
                 options={{
                   about: false,
@@ -80,7 +81,7 @@ export function FollowsRelayHealth({
             .sort((a, b) => (a.count > b.count ? -1 : 1))
             .slice(0, 10)
             .map(a => (
-              <div className="flex justify-between">
+              <div key={a.relay} className="flex justify-between">
                 <div>{getRelayName(a.relay)}</div>
                 <div>
                   {a.count} (<FormattedNumber style="percent" value={a.count / uniqueFollows.length} />)
diff --git a/packages/app/src/Pages/settings/tools/prune-follows.tsx b/packages/app/src/Pages/settings/tools/prune-follows.tsx
index ad0c94e7..f116e15e 100644
--- a/packages/app/src/Pages/settings/tools/prune-follows.tsx
+++ b/packages/app/src/Pages/settings/tools/prune-follows.tsx
@@ -141,7 +141,7 @@ export function PruneFollowList() {
             .sort(([, a], [, b]) => (a > b ? -1 : 1))
             .map(([k, v]) => {
               return (
-                <div className="flex justify-between">
+                <div key={k} className="flex justify-between">
                   <ProfileImage pubkey={k} />
                   <div className="flex flex-col gap-1">
                     <FormattedMessage
diff --git a/packages/app/src/Pages/subscribe/index.tsx b/packages/app/src/Pages/subscribe/index.tsx
index d7b00752..5db6bc08 100644
--- a/packages/app/src/Pages/subscribe/index.tsx
+++ b/packages/app/src/Pages/subscribe/index.tsx
@@ -91,7 +91,7 @@ export function SubscribePage() {
         {Plans.map(a => {
           const lower = Plans.filter(b => b.id < a.id);
           return (
-            <div className={classNames("p flex flex-col g8", { disabled: a.disabled })}>
+            <div key={a.id} className={classNames("p flex flex-col g8", { disabled: a.disabled })}>
               <div className="grow">
                 <h2>{mapPlanName(a.id)}</h2>
                 <p>
@@ -108,10 +108,10 @@ export function SubscribePage() {
                 </p>
                 <ul className="list-disc">
                   {a.unlocks.map(b => (
-                    <li>{mapFeatureName(b)} </li>
+                    <li key={`unlocks-${b}`}>{mapFeatureName(b)} </li>
                   ))}
                   {lower.map(b => (
-                    <li>
+                    <li key={`lower-${b}`}>
                       <FormattedMessage
                         defaultMessage="Everything in {plan}"
                         id="l+ikU1"
diff --git a/yarn.lock b/yarn.lock
index e3c7cc6c..459de9c4 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2964,6 +2964,8 @@ __metadata:
     eslint: ^8.48.0
     eslint-plugin-formatjs: ^4.11.3
     eslint-plugin-react: ^7.33.2
+    eslint-plugin-react-hooks: ^4.6.0
+    eslint-plugin-react-refresh: ^0.4.5
     fuse.js: ^7.0.0
     highlight.js: ^11.8.0
     light-bolt11-decoder: ^2.1.0
@@ -5904,6 +5906,24 @@ __metadata:
   languageName: node
   linkType: hard
 
+"eslint-plugin-react-hooks@npm:^4.6.0":
+  version: 4.6.0
+  resolution: "eslint-plugin-react-hooks@npm:4.6.0"
+  peerDependencies:
+    eslint: ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0
+  checksum: 23001801f14c1d16bf0a837ca7970d9dd94e7b560384b41db378b49b6e32dc43d6e2790de1bd737a652a86f81a08d6a91f402525061b47719328f586a57e86c3
+  languageName: node
+  linkType: hard
+
+"eslint-plugin-react-refresh@npm:^0.4.5":
+  version: 0.4.5
+  resolution: "eslint-plugin-react-refresh@npm:0.4.5"
+  peerDependencies:
+    eslint: ">=7"
+  checksum: 953e665f6aaf097291a2bb07fde05466338aecd169bcd6faa708b50166912e3a757f45a45252cf7738b5e0d986224d363cc227864e98c979fe9978770b2b9f42
+  languageName: node
+  linkType: hard
+
 "eslint-plugin-react@npm:^7.33.2":
   version: 7.33.2
   resolution: "eslint-plugin-react@npm:7.33.2"