From 4bbad0563b02a63a94a13c6747e742df34826cba Mon Sep 17 00:00:00 2001 From: Martti Malmi Date: Tue, 2 Jan 2024 00:25:44 +0200 Subject: [PATCH] useMemo in Avatar --- packages/app/src/Element/User/Avatar.tsx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/app/src/Element/User/Avatar.tsx b/packages/app/src/Element/User/Avatar.tsx index 015b3520..5f1f3fad 100644 --- a/packages/app/src/Element/User/Avatar.tsx +++ b/packages/app/src/Element/User/Avatar.tsx @@ -1,6 +1,6 @@ import "./Avatar.css"; -import { ReactNode, useEffect, useState } from "react"; +import {ReactNode, useMemo} from "react"; import type { UserMetadata } from "@snort/system"; import classNames from "classnames"; @@ -31,10 +31,8 @@ const Avatar = ({ className, showTitle = true, }: AvatarProps) => { - const [url, setUrl] = useState(""); - - useEffect(() => { - setUrl(image ?? user?.picture ?? defaultAvatar(pubkey)); + const url = useMemo(() => { + return image ?? user?.picture ?? defaultAvatar(pubkey); }, [user, image, pubkey]); const s = size ?? 120;