From 910686eab04dcaf2cb6b16f50a89408b91f227c0 Mon Sep 17 00:00:00 2001
From: vivganes <vivek@vivekganesan.com>
Date: Thu, 13 Apr 2023 19:38:00 +0530
Subject: [PATCH] fix review comments

---
 packages/app/src/Element/NoteCreator.tsx | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/app/src/Element/NoteCreator.tsx b/packages/app/src/Element/NoteCreator.tsx
index 566fb4ed..581259ac 100644
--- a/packages/app/src/Element/NoteCreator.tsx
+++ b/packages/app/src/Element/NoteCreator.tsx
@@ -112,7 +112,7 @@ export function NoteCreator() {
     }
   }
 
-  async function uploadFile(file: File) {
+  async function uploadFile(file: File | Blob) {
     setUploadInProgress(true);
     try {
       if (file) {
@@ -122,12 +122,12 @@ export function NoteCreator() {
         } else if (rx?.error) {
           dispatch(setError(rx.error));
         }
-        setUploadInProgress(false);
       }
     } catch (error: unknown) {
       if (error instanceof Error) {
         dispatch(setError(error?.message));
       }
+    } finally {
       setUploadInProgress(false);
     }
   }
@@ -237,8 +237,7 @@ export function NoteCreator() {
       const item = items[0];
       const blob = item.getAsFile();
       if (blob) {
-        const file = new File([blob], "filename.jpg", { type: "image/jpeg", lastModified: new Date().getTime() });
-        uploadFile(file);
+        uploadFile(blob);
       }
     }
   };