nostr package part 2 #346

2023-02-21T23:26:24Z

sistemd commented

2023-02-21 23:26:24 +00:00

(Migrated from github.com)

Implemented the outline I presented in the previous PR. There is enough functionality now to start setting up an automated test suite, which is my plan for the next PR.

cloudflare-pages[bot] commented

2023-02-21 23:26:32 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`2c1c07a`
Status:	✅ Deploy successful!
Preview URL:	https://99404a55.snort-social.pages.dev
Branch Preview URL:	https://nostr-package-2.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>2c1c07a</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://99404a55.snort-social.pages.dev'>https://99404a55.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://nostr-package-2.snort-social.pages.dev'>https://nostr-package-2.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/99404a55-4af4-4cd4-a651-92a34caa9531)

😕 1

v0l (Migrated from github.com) approved these changes 2023-02-22 11:14:04 +00:00

v0l (Migrated from github.com) left a comment

LGTM

v0l commented

2023-02-22 11:14:38 +00:00

(Migrated from github.com)

Build error:



23:26:21.466 | $ tsc
-- | --
23:26:28.958 | src/raw.ts(6,50): error TS2307: Cannot find module './nostr' or its corresponding type declarations.

Build error: ``` 23:26:21.466 | $ tsc -- | -- 23:26:28.958 | src/raw.ts(6,50): error TS2307: Cannot find module './nostr' or its corresponding type declarations. ```

😕 1

sistemd (Migrated from github.com) reviewed 2023-02-22 23:44:23 +00:00

sistemd (Migrated from github.com) reviewed 2023-02-26 22:47:22 +00:00

sistemd commented

2023-02-26 22:50:07 +00:00

(Migrated from github.com)

Fixed the build error, the rest of the comments are all addressed in the next PR.

Sign in to join this conversation.

No reviewers

v0l