Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

Scrolling to note when highlighted #160

Closed
ivanacostarubio wants to merge 4 commits from bootleg into main
pull from: bootleg
merge into: Kieran:main
Conversation 4 Commits 4 Files Changed 1 +16 -2
ivanacostarubio commented 2023-01-28 14:51:04 +00:00 (Migrated from github.com)
Copy Link

It helps when threads are enormous,

but it doesn't allow me to scroll afterward 😞 🤷🏼 ...

Maybe fix with 2edecfa3d2

Ex:

It helps when threads are enormous, > but it doesn't allow me to scroll afterward 😞 🤷🏼 ... Maybe fix with https://github.com/v0l/snort/pull/160/commits/2edecfa3d2dba86304404bf19a4a69f99e85356e Ex: - http://localhost:3000/e/note1uee992wd5gqqma86vhmzgxqsv7n0s9zxhrdu9lg6n62hjjeca7gqr4xqhr - http://localhost:3000/e/note17rrfw2eqdzg5t2zxa8sscp62fy4v94m9qjl55yaaj3e0u8r4qr9szwflrk
verbiricha commented 2023-01-28 15:15:44 +00:00 (Migrated from github.com)
Copy Link

if we end up adding scroll I'd add this to CSS for smooth scrolling:

html {
  scroll-behavior: smooth;
}
if we end up adding scroll I'd add this to CSS for smooth scrolling: ```css html { scroll-behavior: smooth; } ```
ivanacostarubio commented 2023-01-28 15:25:21 +00:00 (Migrated from github.com)
Copy Link

Look how it renders

https://user-images.githubusercontent.com/16559/215274787-a5a81d27-d27a-44b0-9c4e-f4fc1499ffdc.mp4

Look how it renders https://user-images.githubusercontent.com/16559/215274787-a5a81d27-d27a-44b0-9c4e-f4fc1499ffdc.mp4
verbiricha commented 2023-01-29 12:04:58 +00:00 (Migrated from github.com)
Copy Link

I'm reworking threads atm and plan to implement this. I think we can close this one for the time being.

I'm reworking threads atm and plan to implement this. I think we can close this one for the time being.
ivanacostarubio commented 2023-01-29 21:25:18 +00:00 (Migrated from github.com)
Copy Link

:shipit:

:shipit:

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#160
No description provided.
Delete Branch "bootleg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?