Add Wavlake embed #416
No reviewers
Labels
No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Kieran/snort#416
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "add-wavlake-music-embed"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This enables the display of an embedded music player when people share links to tracks on Wavlake. The embedded player also is capable of boosting the track if the Alby extension (WebLN) is available and the wallet is capable of sending keysends. The boost button is not visible if WebLN is not available.
lgtm, but can you run
yarn workspace @snort/app format
to prettify your changes?also, what do you think about removing the max width of the player? imo it looks better and that's how all the other player embeds are.
Also heads up that the payment button doesn't work for me with Alby. I think i have the default setup with Alby.
Thanks @SamSamskies Prettified changes as requested.
Also yes, good call on layout. I extended the max width of the embedded player to take up the width of the component. See screenshot below.
As for the Alby failure, what you're seeing is expected if the wallet/node you're connected to does not support keysends. Planning to support more widely available payment methods in the future but keysend is available now and would like to roll this out for anyone who's interested in trying it.
🚀
@blastshielddown looks like you need to sign your commits. could you rebase and sign your commits?
@SamSamskies Rebased and signed