Kieran/zap.stream
5
8
Fork 9
Code Issues 29 Pull Requests 1 Packages Projects 1 Releases Wiki Activity

Hide followed hashtags when no streams are live #108

Merged
Kieran merged 2 commits from florian/stream:fix/hide-followed-hashtags-with-no-streams into main 2023-12-06 16:05:12 +00:00
Conversation 0 Commits 2 Files Changed 1 +20 -12
florian commented 2023-12-05 16:27:05 +00:00
Contributor
Copy Link

I have followed some hashtags and they always show up as empty sections in zap.stream even when there is no live stream using these hashtags.

I moved the filtering of the live streams to a useMemo and added a check if there are any live streams >0 for the given hashtag.

This hides the hashtag sections if there are no matching live streams.

I have followed some hashtags and they always show up as empty sections in zap.stream even when there is no live stream using these hashtags. I moved the filtering of the live streams to a useMemo and added a check if there are any live streams >0 for the given hashtag. This hides the hashtag sections if there are no matching live streams.
florian added 1 commit 2023-12-05 16:27:11 +00:00
fix: Hide followed hashtags when no streams are live
Some checks reported errors
continuous-integration/drone/pr Build encountered an error
Details
20f5554a48
florian added 1 commit 2023-12-05 22:40:12 +00:00
Merge branch 'main' into fix/hide-followed-hashtags-with-no-streams
Some checks reported errors
continuous-integration/drone/pr Build encountered an error
Details
d3c2d508e5
Kieran approved these changes 2023-12-06 16:04:56 +00:00
Kieran merged commit a36ef90f88 into main 2023-12-06 16:05:12 +00:00
Kieran deleted branch fix/hide-followed-hashtags-with-no-streams 2023-12-06 16:05:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Kieran
Labels
Clear labels   
backend

An issue related to the hosted streaming backend

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
needs:design

   
P1

   
P2

   
P3

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
backend
bug
duplicate
enhancement
help wanted
invalid
needs:design
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/zap.stream#108
No description provided.
Delete Branch "florian/stream:fix/hide-followed-hashtags-with-no-streams"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?