Kieran/zap.stream
5
8
Fork 9
Code Issues 29 Pull Requests 1 Packages Projects 1 Releases Wiki Activity

profile page #16

Merged
Kieran merged 8 commits from verbiricha/stream:profile into main 2023-07-01 16:57:14 +00:00
Conversation 0 Commits 8 Files Changed 30 +939 -193
verbiricha commented 2023-06-30 17:09:02 +00:00
Collaborator
Copy Link

resolves #13
resolves #15

resolves #13 resolves #15
verbiricha added 2 commits 2023-06-30 17:09:05 +00:00
verbiricha added 1 commit 2023-06-30 17:13:08 +00:00
verbiricha added 1 commit 2023-06-30 20:33:20 +00:00
verbiricha added 1 commit 2023-06-30 20:37:29 +00:00
verbiricha added 1 commit 2023-06-30 20:39:49 +00:00
verbiricha added 2 commits 2023-07-01 16:45:14 +00:00
Kieran reviewed 2023-07-01 16:52:02 +00:00
src/hooks/profile.ts
@ -0,0 +26,4 @@
const { data: streamsData } = useRequestBuilder<ReplaceableNoteStore>(
System,
ReplaceableNoteStore,
Kieran commented 2023-06-30 22:00:22 +00:00
Owner
Copy Link

This store should be ParameterizedReplaceableNoteStore for d-tag events

This store should be `ParameterizedReplaceableNoteStore` for d-tag events
src/pages/profile-page.css
@ -0,0 +4,4 @@
}
.profile-page .profile-container {
max-width: 620px;
Kieran commented 2023-06-30 21:52:49 +00:00
Owner
Copy Link

This is kinda weird because my profile is not as wide as some others because of the banner image, maybe it should just be fixed width

This is kinda weird because my profile is not as wide as some others because of the banner image, maybe it should just be fixed width
src/pages/profile-page.tsx
@ -0,0 +70,4 @@
function goToLive() {
if (liveEvent) {
const d =
liveEvent.tags?.find((t: string[]) => t?.at(0) === "d")?.at(1) || "";
Kieran commented 2023-06-30 21:57:13 +00:00
Owner
Copy Link

You can use the helper function for this one findTag(liveEvent, "d") ?? ""

You can use the helper function for this one `findTag(liveEvent, "d") ?? ""`
Kieran merged commit d1579a9be1 into main 2023-07-01 16:57:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

An issue related to the hosted streaming backend

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
needs:design

   
P1

   
P2

   
P3

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
backend
bug
duplicate
enhancement
help wanted
invalid
needs:design
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/zap.stream#16
No description provided.
Delete Branch "verbiricha/stream:profile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?