Kieran/zap.stream
5
8
Fork 9
Code Issues 29 Pull Requests 1 Packages Projects 1 Releases Wiki Activity

feat: show chat message zaps and reactions #19

Merged
Kieran merged 22 commits from verbiricha/stream:message-zaps into main 2023-07-04 18:12:51 +00:00
Conversation 2 Commits 22 Files Changed 16 +590 -82
verbiricha commented 2023-07-02 21:00:50 +00:00
Collaborator
Copy Link
  • Allows to zap/react to a message by clicking or hovering the message
  • Shows zap amounts for messages
  • Shows reactions as emoji for messages
  • Autocomplete emoji and custom emotes in message composer
- Allows to zap/react to a message by clicking or hovering the message - Shows zap amounts for messages - Shows reactions as emoji for messages - Autocomplete emoji and custom emotes in message composer
verbiricha added 4 commits 2023-07-02 21:00:53 +00:00
verbiricha commented 2023-07-03 06:28:18 +00:00
Author
Collaborator
Copy Link

Discussing some UI/UX improvements with Karnage for this, pls don't merge yet.

Discussing some UI/UX improvements with Karnage for this, pls don't merge yet.
verbiricha added 1 commit 2023-07-03 08:20:57 +00:00
verbiricha added 1 commit 2023-07-03 12:02:26 +00:00
verbiricha added 1 commit 2023-07-03 12:03:59 +00:00
verbiricha added 2 commits 2023-07-03 12:08:24 +00:00
verbiricha added 1 commit 2023-07-03 12:59:37 +00:00
verbiricha added 1 commit 2023-07-03 14:28:36 +00:00
verbiricha added 1 commit 2023-07-03 14:30:15 +00:00
verbiricha added 1 commit 2023-07-03 16:27:57 +00:00
verbiricha added 1 commit 2023-07-03 17:07:51 +00:00
verbiricha added 1 commit 2023-07-03 20:56:30 +00:00
verbiricha added 1 commit 2023-07-03 21:12:16 +00:00
verbiricha added 1 commit 2023-07-03 21:16:48 +00:00
verbiricha added 1 commit 2023-07-04 14:25:46 +00:00
verbiricha added 1 commit 2023-07-04 14:27:33 +00:00
verbiricha added 2 commits 2023-07-04 14:36:42 +00:00
Kieran reviewed 2023-07-04 15:07:07 +00:00
src/element/live-chat.tsx Outdated
@ -117,0 +264,4 @@
setShowZapDialog(false);
try {
const pub = await EventPublisher.nip7();
const reply = await pub?.generic((eb) => {
Kieran commented 2023-07-04 14:55:09 +00:00
Owner
Copy Link

There should be a react function on EventPublisher

There should be a `react` function on EventPublisher
Kieran marked this conversation as resolved
src/element/live-chat.tsx
@ -122,0 +333,4 @@
{zapTarget && (
<SendZapsDialog
lnurl={zapTarget}
aTag={
Kieran commented 2023-07-04 14:58:27 +00:00
Owner
Copy Link

Dont think we need to zap the stream when zapping chat message, just zap comment is fine

Dont think we need to zap the stream when zapping chat message, just zap comment is fine
Kieran marked this conversation as resolved
src/hooks/profile.ts Outdated
@ -24,0 +26,4 @@
b2.withOptions({
leaveOpen,
})
.withFilter()
Kieran commented 2023-07-04 15:05:33 +00:00
Owner
Copy Link

No need for b2 here you can use b.withFilter() again to add another

No need for `b2` here you can use `b.withFilter()` again to add another
Kieran marked this conversation as resolved
verbiricha added 1 commit 2023-07-04 17:30:54 +00:00
verbiricha commented 2023-07-04 17:31:18 +00:00
Author
Collaborator
Copy Link

@Kieran good points, fixed in faf75eba69

@Kieran good points, fixed in https://git.v0l.io/Kieran/stream/commit/faf75eba69368a98e072ff060c2b74eb8e3c1c70
Kieran merged commit 7eeec29beb into main 2023-07-04 18:12:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

An issue related to the hosted streaming backend

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
needs:design

   
P1

   
P2

   
P3

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
backend
bug
duplicate
enhancement
help wanted
invalid
needs:design
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/zap.stream#19
No description provided.
Delete Branch "verbiricha/stream:message-zaps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?