feat: stream cards improvements #47

verbiricha · 2023-07-28T10:03:04Z

verbiricha commented

2023-07-28 10:03:04 +00:00

edit toggle
reorder with drag and drop
delete button inside edit modal
add ability to clear image from card
make card textarea taller and avoid horizontal resize

- edit toggle - reorder with drag and drop - delete button inside edit modal - add ability to clear image from card - make card textarea taller and avoid horizontal resize

verbiricha added 1 commit 2023-07-28 10:03:05 +00:00

feat: stream cards improvements 4e4ea9efa6

- edit toggle
- reorder with drag and drop
- delete button inside edit modal
- add ability to clear image from card
- make card textarea taller and avoid horizontal resize

verbiricha commented

2023-07-28 10:07:26 +00:00

Adding some UI improvements as well, talking to Karnage about it, don't merge yet.

verbiricha added 1 commit 2023-07-28 10:18:03 +00:00

cleanup card UI d8a9aee136

verbiricha commented

2023-07-28 10:19:00 +00:00

UI improvements added, now cards don't have padding/background or border and looks cleaner. It will also show different column amounts depending on resolution and columns take all available space.

TheGrinder referenced this pull request

2023-07-28 16:16:08 +00:00

Suggestions - cards #46

verbiricha added 1 commit 2023-07-29 22:30:58 +00:00

fix: limit image sizes f0829f35e1

verbiricha added 1 commit 2023-07-30 08:32:45 +00:00

fix: limit card width 427613245a

verbiricha added 1 commit 2023-07-30 08:42:37 +00:00

fix: big ass images 69231cf917

verbiricha added 1 commit 2023-07-31 08:10:15 +00:00

fix: 100 percent width 9674e17c14

Kieran reviewed 2023-07-31 10:07:10 +00:00

src/element/toggle.tsx

						
				@ -0,0 +7,4 @@

				function ToggleLeft(props) {

				  return (

				    <svg viewBox="0 0 24 24" fill="none" {...props}>

Kieran commented

2023-07-31 10:06:09 +00:00

Why not use <Icon> ?

Why not use `<Icon>` ?

verbiricha commented

2023-07-31 16:27:47 +00:00

mb, using icon now

Kieran marked this conversation as resolved

verbiricha added 1 commit 2023-07-31 16:11:37 +00:00

refactor: use icon component 99e5b9688f

Kieran approved these changes 2023-07-31 21:31:00 +00:00

Kieran merged commit 1229eee15e into main

2023-07-31 21:31:35 +00:00

Kieran referenced this issue from a commit

2023-07-31 21:31:35 +00:00

Merge pull request 'feat: stream cards improvements' (#47) from cards-improvements into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/zap.stream#47