home improvements #54

verbiricha · 2023-07-31T17:24:06Z

verbiricha commented

2023-07-31 17:24:06 +00:00

show followed streams first
show stream hashtags in video tile
show followed hashtags sections
allow to visit hashtag page by clicking tag
allow to follow/unfollow hashtags

- show followed streams first - show stream hashtags in video tile - show followed hashtags sections - allow to visit hashtag page by clicking tag - allow to follow/unfollow hashtags

verbiricha added 2 commits 2023-07-31 17:24:07 +00:00

feat: mute list e726a67413

homepage improvements 75ff1dc376

- show followed streams first
- show stream hashtags in video tile
- allow to visit hashtag page by clicking tag
- allow to follow/unfollow hashtags

verbiricha added 1 commit 2023-07-31 20:55:31 +00:00

fix: typo bd3d566c3f

Kieran reviewed 2023-07-31 21:21:23 +00:00

src/element/video-tile.tsx Outdated

						
				@ -43,2 +51,4 @@

				          })`,

				        }}

				      >

				        <div className="video-tags">

Kieran commented

2023-07-31 21:05:02 +00:00

These will get blurred when nsfw, that is why viewers is outside this div

Kieran marked this conversation as resolved

src/hooks/live-streams.ts

						
				@ -0,0 +22,4 @@

				    } else {

				      rb.withFilter()

				        .kinds([LIVE_STREAM])

				        .since(unixNow() - 86400);

Kieran commented

2023-07-31 21:05:49 +00:00

using unixNow() in here is sketchy, better to pass the value in and cached because this value keeps changing on rebuild

using `unixNow()` in here is sketchy, better to pass the value in and cached because this value keeps changing on rebuild

Kieran marked this conversation as resolved

src/pages/root.tsx Outdated

						
				@ -48,0 +15,4 @@

				    return login?.follows.tags?.find((t) => t.at(1) === getHost(ev));

				  };

				  const hashtags = getTagValues(login?.follows.tags ?? [], "t");

				  const following = dedupeByHost(live.filter(followsHost));

Kieran commented

2023-07-31 21:08:17 +00:00

I dont think it makes sense to dedupe by host btw, because if the events are manually published it can cause an issue

Kieran marked this conversation as resolved

src/pages/root.tsx

						
				@ -66,0 +32,4 @@

				          ))}

				        </div>

				      )}

				      {!hasFollowingLive && (

Kieran commented

2023-07-31 21:21:20 +00:00

What does root page look like now, can you include screenshots?

Kieran marked this conversation as resolved

Kieran changed title from ~~home improvements~~ to home improvements

2023-07-31 21:32:55 +00:00

Kieran changed target branch from mute/block to main

2023-07-31 21:32:59 +00:00

verbiricha added 3 commits 2023-08-01 06:11:16 +00:00

fix: show tags outside video tile 5026f6a008

refactor: cache since, dont dedupe by host 58c55f17b6

refactor: useCallback 1baecf41f2

verbiricha commented

2023-08-01 06:13:34 +00:00

good points @Kieran, did some changes:

show tags outside video preview, allowing to click on tag links and profile link
use cached "since" value
remove dedupes by host

recorded a vid of how it looks like now when logged in, logged out is the same:

https://void.cat/5HHAVavQS4Y7FEQurhMP1H

good points @Kieran, did some changes: - show tags outside video preview, allowing to click on tag links and profile link - use cached "since" value - remove dedupes by host recorded a vid of how it looks like now when logged in, logged out is the same: https://void.cat/5HHAVavQS4Y7FEQurhMP1H

verbiricha added 1 commit 2023-08-01 08:23:00 +00:00

fix: logout emoji packs 0fcb712759

Kieran approved these changes 2023-08-01 09:16:01 +00:00

Kieran referenced this issue from a commit

2023-08-01 09:16:12 +00:00

Merge pull request 'home improvements' (#54) from home into main

Kieran merged commit 56783bfc8d into main

2023-08-01 09:16:13 +00:00

Sign in to join this conversation.

No reviewers