Kieran/void-cat-rs
2
0
Fork 1
Code Issues 4 Pull Requests 1 Packages Projects Releases Wiki Activity

Toggle for Blossom and NIP96 #5

New Issue
Closed
opened 2024-08-30 17:44:19 +00:00 by sjors · 6 comments
sjors commented 2024-08-30 17:44:19 +00:00
Copy Link

At some point I may want to turn one of these mechanisms off, so it's nice if config.toml can do that.

At some point I may want to turn one of these mechanisms off, so it's nice if `config.toml` can do that.
Kieran added the
enhancement
 label 2024-08-30 17:45:32 +00:00
Kieran commented 2024-08-30 17:46:07 +00:00
Owner
Copy Link

Yea i was just thinking that, would be good to use feature flags for nip96 and blossom so you can disable some if you dont want them (like having ffmpeg dependency for nip96)

Yea i was just thinking that, would be good to use feature flags for nip96 and blossom so you can disable some if you dont want them (like having ffmpeg dependency for nip96)
sjors commented 2024-08-30 18:20:12 +00:00
Author
Copy Link

If ffmpeg is only needed for nip96 then I suppose you would also need a way to avoid it in the build?

If `ffmpeg` is only needed for nip96 then I suppose you would also need a way to avoid it in the build?
Kieran referenced this issue from a commit 2024-08-30 18:58:45 +00:00
Feature flag nip96/blossom
Kieran commented 2024-08-30 19:00:19 +00:00
Owner
Copy Link

You should be able to build without ffmpeg using the feature flags

cargo build --release --no-default-features --features blossom

You should be able to build without ffmpeg using the feature flags `cargo build --release --no-default-features --features blossom`
sjors commented 2024-08-30 20:28:00 +00:00
Author
Copy Link

Are you sure none of these dependencies are needed for Blossom? Now I'm getting a Outcome: Success(500 Internal Server Error) again after a successful void_cat::auth::blossom.

Are you sure none of these dependencies are needed for Blossom? Now I'm getting a `Outcome: Success(500 Internal Server Error)` again after a successful ` void_cat::auth::blossom`.
Kieran commented 2024-08-30 21:01:25 +00:00
Owner
Copy Link

Yes it works, although it seems the blossom spec changed since i looked at it before.

I pushed some fixes just now

Yes it works, although it seems the blossom spec changed since i looked at it before. I pushed some fixes just now
sjors commented 2024-08-31 12:36:11 +00:00
Author
Copy Link

Works like a charm with noStrudel (next): https://njump.me/nevent1qqsfxk89smn6df3472gmadnk45826n33u8dwr5jn5fvrq4859hw4acspz4mhxue69uhhyetvv9ujumt0wd68ytnsw43qz9rhwden5te0dehhxarj9cchxct59ehhyecpz3mhxue69uhhyetvv9ujuerpd46hxtnfduqs6amnwvaz7tmwdaejumr0dsd9qjkt

Works like a charm with noStrudel (next): https://njump.me/nevent1qqsfxk89smn6df3472gmadnk45826n33u8dwr5jn5fvrq4859hw4acspz4mhxue69uhhyetvv9ujumt0wd68ytnsw43qz9rhwden5te0dehhxarj9cchxct59ehhyecpz3mhxue69uhhyetvv9ujuerpd46hxtnfduqs6amnwvaz7tmwdaejumr0dsd9qjkt
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/void-cat-rs#5
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?