Fernando Porazzi fernandoporazzi
0 Followers · 0 Following
  • Joined on 2023-08-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
fernandoporazzi opened issue Kieran/snort#627 2023-09-03 19:18:22 +00:00
Allow translation of notes
fernandoporazzi opened issue Kieran/snort#626 2023-09-01 15:27:37 +00:00
Images could be rendered as a carousel or grid at the bottom of the note
fernandoporazzi commented on pull request Kieran/snort#625 2023-09-01 13:15:54 +00:00
feat: highlight search results

Implemented!

fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-09-01 13:14:03 +00:00
c223c89045 feat: highlight search results
fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-09-01 13:12:36 +00:00
b2d17eab25 feat: highlight search results
fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-09-01 13:09:53 +00:00
4bdf94e444 feat: highlight search results
fernandoporazzi commented on pull request Kieran/snort#625 2023-09-01 09:15:22 +00:00
feat: highlight search results

I tried to co-locate the function extractHighlightedText inside this useMemo, however all the content already has a type(hashtag, text, media and so on...) and it's quite tricky then.

So…

fernandoporazzi commented on pull request Kieran/snort#625 2023-08-31 11:39:17 +00:00
feat: highlight search results

I don't know if I fully agree about moving the logic of this specific fragment inside this useMemo. All fragment-related logic now lives in a single place and it's easy to reason. Eventually the…

fernandoporazzi commented on pull request Kieran/snort#625 2023-08-31 10:41:15 +00:00
feat: highlight search results

New implementation submitted. Preview:

fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-08-31 10:30:59 +00:00
501f8694c5 feat: highlight search results
fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-08-31 10:30:10 +00:00
b318a102b6 feat: highlight search results
fernandoporazzi commented on pull request Kieran/snort#625 2023-08-31 10:27:42 +00:00
feat: highlight search results

I implemented the changes using the transformText approach. Now there is a new type for the ParsedFragment interface.

fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-08-31 10:25:33 +00:00
a6d5aa9453 feat: highlight search results
fernandoporazzi commented on pull request Kieran/snort#625 2023-08-30 15:42:13 +00:00
feat: highlight search results

What would you suggest as an alternative?

fernandoporazzi commented on pull request Kieran/snort#625 2023-08-30 14:07:35 +00:00
feat: highlight search results

Hey @Giszmo, it will work for multiple words. However the highlight is just being applied exactly on what was typed.

On the second image, I search for two words in isolation,…

fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-08-30 14:06:47 +00:00
4a5e32d4d4 feat: highlight search results
fernandoporazzi commented on pull request Kieran/snort#625 2023-08-30 13:55:17 +00:00
feat: highlight search results

Hey @Giszmo, it will work for multiple words. However the highlight is just being applied exactly on what was typed.

On the second image, I search for two words in isolation, however…

fernandoporazzi commented on pull request Kieran/snort#625 2023-08-30 12:51:26 +00:00
feat: highlight search results

Hey @Giszmo, it will work for multiple words. Check this:

fernandoporazzi pushed to highlight-searched-word at fernandoporazzi/snort 2023-08-30 10:51:14 +00:00
07bb3cca2f feat: highlight search results
fernandoporazzi created pull request Kieran/snort#625 2023-08-30 10:49:41 +00:00
feat: highlight search results