mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2024-09-19 21:06:42 +00:00
1263b0a6ca
AVMediaCodecDeviceContext without surface or native_window is useless, it shouldn't be created at all. Such dummy AVHWDeviceContext is allowed before, and it's used by mpv player. Creating a ANativeWindow automatically breaks such usecases. So disable creating a ANativeWindow by default. It can be enabled via the create_window flag, or by set the AVDictionary of av_hwdevice_ctx_create(). The downside is that ffmpeg -hwaccel mediacodec -i input.mp4 \ -c:a copy -c:v hevc_mediacodec output.mp4 use ByteBuffer mode which isn't as efficient as before. The upside is libavfilter works now, which should be less surprise. To enable create_window on ffmpeg command line, use ffmpeg -hwaccel mediacodec \ -init_hw_device mediacodec=mediacodec,create_window=1 \ -i input.mp4 -c:a copy -c:v hevc_mediacodec output.mp4 Users should know what it is to enable create_window. It should be OK to take sometime to figure out the option. And there are comments inside hwcontext_mediacodec.h to help user figure it out. Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
62 lines
1.9 KiB
C
62 lines
1.9 KiB
C
/*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef AVUTIL_HWCONTEXT_MEDIACODEC_H
|
|
#define AVUTIL_HWCONTEXT_MEDIACODEC_H
|
|
|
|
/**
|
|
* MediaCodec details.
|
|
*
|
|
* Allocated as AVHWDeviceContext.hwctx
|
|
*/
|
|
typedef struct AVMediaCodecDeviceContext {
|
|
/**
|
|
* android/view/Surface handle, to be filled by the user.
|
|
*
|
|
* This is the default surface used by decoders on this device.
|
|
*/
|
|
void *surface;
|
|
|
|
/**
|
|
* Pointer to ANativeWindow.
|
|
*
|
|
* It both surface and native_window is NULL, try to create it
|
|
* automatically if create_window is true and OS support
|
|
* createPersistentInputSurface.
|
|
*
|
|
* It can be used as output surface for decoder and input surface for
|
|
* encoder.
|
|
*/
|
|
void *native_window;
|
|
|
|
/**
|
|
* Enable createPersistentInputSurface automatically.
|
|
*
|
|
* Disabled by default.
|
|
*
|
|
* It can be enabled by setting this flag directly, or by setting
|
|
* AVDictionary of av_hwdevice_ctx_create(), with "create_window" as key.
|
|
* The second method is useful for ffmpeg cmdline, e.g., we can enable it
|
|
* via:
|
|
* -init_hw_device mediacodec=mediacodec,create_window=1
|
|
*/
|
|
int create_window;
|
|
} AVMediaCodecDeviceContext;
|
|
|
|
#endif /* AVUTIL_HWCONTEXT_MEDIACODEC_H */
|