mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2024-09-24 15:21:22 +00:00
2170017a1c
Make the one-time initialization in av_get_cpu_flags() thread-safe. The
static variables |flags|, |cpuflags_mask|, and |checked| in
libavutil/cpu.c are read and written using normal load and store
operations. These are considered as data races. The fix is to use atomic
load and store operations.
Remove the |checked| variable because the invalid value of -1 for
|flags| can be used to indicate the same condition. Rename |flags| to
|cpu_flags| and move it to file scope.
The fix can be verified by running the libavutil/tests/cpu_init.c test
program under ThreadSanitizer:
./configure --toolchain=clang-tsan
make libavutil/tests/cpu_init
libavutil/tests/cpu_init
There should be no warnings from ThreadSanitizer.
Co-author: Dmitry Vyukov of Google, who suggested the data race fix.
Signed-off-by: Wan-Teh Chang <wtc@google.com>
84 lines
2.5 KiB
Makefile
84 lines
2.5 KiB
Makefile
FATE_LIBAVUTIL += fate-adler32
|
|
fate-adler32: libavutil/tests/adler32$(EXESUF)
|
|
fate-adler32: CMD = run libavutil/tests/adler32
|
|
fate-adler32: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-aes
|
|
fate-aes: libavutil/tests/aes$(EXESUF)
|
|
fate-aes: CMD = run libavutil/tests/aes
|
|
fate-aes: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-avstring
|
|
fate-avstring: libavutil/tests/avstring$(EXESUF)
|
|
fate-avstring: CMD = run libavutil/tests/avstring
|
|
|
|
FATE_LIBAVUTIL += fate-base64
|
|
fate-base64: libavutil/tests/base64$(EXESUF)
|
|
fate-base64: CMD = run libavutil/tests/base64
|
|
|
|
FATE_LIBAVUTIL += fate-blowfish
|
|
fate-blowfish: libavutil/tests/blowfish$(EXESUF)
|
|
fate-blowfish: CMD = run libavutil/tests/blowfish
|
|
|
|
FATE_LIBAVUTIL += fate-cpu
|
|
fate-cpu: libavutil/tests/cpu$(EXESUF)
|
|
fate-cpu: CMD = run libavutil/tests/cpu $(CPUFLAGS:%=-c%) $(THREADS:%=-t%)
|
|
fate-cpu: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL-$(HAVE_THREADS) += fate-cpu_init
|
|
fate-cpu_init: libavutil/tests/cpu_init$(EXESUF)
|
|
fate-cpu_init: CMD = run libavutil/tests/cpu_init
|
|
fate-cpu_init: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-crc
|
|
fate-crc: libavutil/tests/crc$(EXESUF)
|
|
fate-crc: CMD = run libavutil/tests/crc
|
|
|
|
FATE_LIBAVUTIL += fate-des
|
|
fate-des: libavutil/tests/des$(EXESUF)
|
|
fate-des: CMD = run libavutil/tests/des
|
|
fate-des: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-eval
|
|
fate-eval: libavutil/tests/eval$(EXESUF)
|
|
fate-eval: CMD = run libavutil/tests/eval
|
|
|
|
FATE_LIBAVUTIL += fate-fifo
|
|
fate-fifo: libavutil/tests/fifo$(EXESUF)
|
|
fate-fifo: CMD = run libavutil/tests/fifo
|
|
|
|
FATE_LIBAVUTIL += fate-float-dsp
|
|
fate-float-dsp: libavutil/tests/float_dsp$(EXESUF)
|
|
fate-float-dsp: CMD = run libavutil/tests/float_dsp
|
|
fate-float-dsp: CMP = null
|
|
fate-float-dsp: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-hmac
|
|
fate-hmac: libavutil/tests/hmac$(EXESUF)
|
|
fate-hmac: CMD = run libavutil/tests/hmac
|
|
|
|
FATE_LIBAVUTIL += fate-md5
|
|
fate-md5: libavutil/tests/md5$(EXESUF)
|
|
fate-md5: CMD = run libavutil/tests/md5
|
|
|
|
FATE_LIBAVUTIL += fate-parseutils
|
|
fate-parseutils: libavutil/tests/parseutils$(EXESUF)
|
|
fate-parseutils: CMD = run libavutil/tests/parseutils
|
|
|
|
FATE_LIBAVUTIL += fate-sha
|
|
fate-sha: libavutil/tests/sha$(EXESUF)
|
|
fate-sha: CMD = run libavutil/tests/sha
|
|
|
|
FATE_LIBAVUTIL += fate-tree
|
|
fate-tree: libavutil/tests/tree$(EXESUF)
|
|
fate-tree: CMD = run libavutil/tests/tree
|
|
fate-tree: REF = /dev/null
|
|
|
|
FATE_LIBAVUTIL += fate-xtea
|
|
fate-xtea: libavutil/tests/xtea$(EXESUF)
|
|
fate-xtea: CMD = run libavutil/tests/xtea
|
|
|
|
FATE_LIBAVUTIL += $(FATE_LIBAVUTIL-yes)
|
|
FATE-$(CONFIG_AVUTIL) += $(FATE_LIBAVUTIL)
|
|
fate-libavutil: $(FATE_LIBAVUTIL)
|