huggingface/candle
1
0
Fork 0
mirror of https://github.com/huggingface/candle.git synced 2025-06-18 11:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some todos.

Browse Source
This commit is contained in:
laurent
2023-06-28 14:33:06 +01:00
parent caafef6cc1
commit 1c755c0e5b
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
candle-core/src/cpu_backend.rs
View File

@ -577,7 +577,6 @@ impl CpuStorage {
layout_f: &Layout, layout_f: &Layout,
) -> Result<Self> { ) -> Result<Self> {
// TODO: Support types that could be casted to a boolean. // TODO: Support types that could be casted to a boolean.
// TODO: this should use the layout.
let pred = self.as_slice::<u32>()?; let pred = self.as_slice::<u32>()?;
match (t, f) { match (t, f) {
(Self::BF16(t), Self::BF16(f)) => { (Self::BF16(t), Self::BF16(f)) => {
@ -615,7 +614,6 @@ impl CpuStorage {
hidden_size: usize, hidden_size: usize,
vocab_size: usize, vocab_size: usize,
) -> Result<Self> { ) -> Result<Self> {
// TODO: this should use the layout.
let ids = self.as_slice::<u32>()?; let ids = self.as_slice::<u32>()?;
map1!(vs, take_impl1, ids, layout, vocab_size, hidden_size) map1!(vs, take_impl1, ids, layout, vocab_size, hidden_size)
} }