Address comments.

This commit is contained in:
Nicolas Patry
2023-06-23 13:42:45 +02:00
parent 96289bce08
commit 2fb87edda5
2 changed files with 9 additions and 4 deletions

View File

@ -128,8 +128,8 @@ impl Storage {
hidden_size: usize,
vocab_size: usize,
) -> Result<Self> {
self.same_device(rhs, "matmul")?;
self.same_dtype(rhs, "matmul")?;
self.same_device(rhs, "embedding")?;
self.same_dtype(rhs, "embedding")?;
match (self, rhs) {
(Storage::Cpu(lhs), Storage::Cpu(rhs)) => {
let storage = lhs.embedding_impl(rhs, hidden_size, vocab_size)?;