From 871efc0307e39441236327643abb397b3ab200d0 Mon Sep 17 00:00:00 2001 From: Laurent Mazare Date: Mon, 11 Sep 2023 23:11:27 +0100 Subject: [PATCH] Bugfix for the conv2d cpu kernel. (#820) --- candle-core/src/cpu_backend.rs | 2 +- candle-nn/examples/cpu_benchmarks.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/candle-core/src/cpu_backend.rs b/candle-core/src/cpu_backend.rs index ee227ef9..544ce32d 100644 --- a/candle-core/src/cpu_backend.rs +++ b/candle-core/src/cpu_backend.rs @@ -1209,7 +1209,7 @@ impl Map1 for Im2Col { let dst_idx = dst_idx + h_k_idx * w_k; for w_k_idx in 0..w_k { let src_w = w_idx * stride + w_k_idx * dilation; - if padding != 0 && (src_w < padding || src_w >= h + padding) { + if padding != 0 && (src_w < padding || src_w >= w + padding) { continue; } let src_w = src_w - padding; diff --git a/candle-nn/examples/cpu_benchmarks.rs b/candle-nn/examples/cpu_benchmarks.rs index 5fb99625..204a7109 100644 --- a/candle-nn/examples/cpu_benchmarks.rs +++ b/candle-nn/examples/cpu_benchmarks.rs @@ -84,7 +84,7 @@ impl candle::CustomOp1 for Im2Col { let dst_idx = dst_idx + h_k_idx * w_k; for w_k_idx in 0..w_k { let src_w = w_idx * stride + w_k_idx * dilation; - if padding != 0 && (src_w < padding || src_w >= h + padding) { + if padding != 0 && (src_w < padding || src_w >= w + padding) { continue; } let src_w = src_w - padding;