huggingface/candle
1
0
Fork 0
mirror of https://github.com/huggingface/candle.git synced 2025-06-16 18:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Really unique identifier for metal device ids. (#1932)

Browse Source 
* Really unique identifier for metal device ids.

* Same device.
This commit is contained in:
Laurent Mazare
2024-03-25 11:48:16 +01:00
committed by GitHub
parent e7f8e72588
commit cd254074f3
2 changed files with 37 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
candle-core/src/storage.rs
View File

@ -44,9 +44,19 @@ impl Storage {
}
pub(crate) fn same_device(&self, rhs: &Self, op: &'static str) -> Result<()> {
let lhs = self.device().location();
let rhs = rhs.device().location();
if lhs != rhs {
let lhs_device = self.device();
let rhs_device = rhs.device();
let lhs = lhs_device.location();
let rhs = rhs_device.location();
let same_device = if self.device().is_metal() {
// On metal, we require the device to be exactly the same rather than
// having the same location. In cuda this is not necessary as all CudaDevice on the
// same GPU will use the same cuda stream.
lhs_device.same_device(&rhs_device)
} else {
lhs == rhs
};
if !same_device {
Err(Error::DeviceMismatchBinaryOp { lhs, rhs, op }.bt())
} else {
Ok(())