From ce27073febe14e1c1a9fe521fc46163ae2aaa820 Mon Sep 17 00:00:00 2001
From: Nicolas Patry <patry.nicolas@protonmail.com>
Date: Thu, 6 Jul 2023 23:59:54 +0200
Subject: [PATCH] Update candle-core/src/safetensors.rs

---
 candle-core/src/safetensors.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/candle-core/src/safetensors.rs b/candle-core/src/safetensors.rs
index d7343e44..f65bd3e2 100644
--- a/candle-core/src/safetensors.rs
+++ b/candle-core/src/safetensors.rs
@@ -71,6 +71,8 @@ fn convert_<T: WithDType>(view: st::TensorView<'_>, device: &Device) -> Result<T
         let data: &[T] = unsafe { std::slice::from_raw_parts(v.as_ptr() as *const T, elem_count) };
         Tensor::from_slice(data, view.shape(), device)
     } else {
+        // XXX: We need to specify `T` here, otherwise the compiler will infer u8 because of the following cast
+        // Making this vector too small to fit a full f16/f32/f64 weights, resulting in out-of-bounds access
         let mut c: Vec<T> = Vec::with_capacity(elem_count);
         // SAFETY: We just created c, so the allocated memory is necessarily
         // contiguous and non overlapping with the view's data.