From dfabc708f29b9b9ae44ded508db6da391f0b2f0f Mon Sep 17 00:00:00 2001 From: Laurent Mazare Date: Thu, 13 Jul 2023 11:11:37 +0100 Subject: [PATCH] Fix a comment. (#155) --- candle-core/src/tensor.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/candle-core/src/tensor.rs b/candle-core/src/tensor.rs index e06f1d37..b9edfedc 100644 --- a/candle-core/src/tensor.rs +++ b/candle-core/src/tensor.rs @@ -19,12 +19,13 @@ impl TensorId { pub struct Tensor_ { id: TensorId, - // Storage uses a mutex here so inner mutability is available and borrow rules are checked - // dynamically. The alternatives would be: + // As we provide inner mutability on the tensor content, the alternatives are: // - Using a mutex, this would have the highest cost when retrieving the storage but would // prevent errors when concurrent access takes place. Mutex would also be subject to // deadlocks for example using the current code if the same tensor is used twice by a single // binary op. + // - Using a refcell unsafe cell would have some intermediary cost, borrow checking would be + // verified dynamically, but the resulting tensors would not be send or sync. // - Using an unsafe cell would have the lowest cost but undefined behavior on concurrent // accesses. // Ideally, we would use Arc for tensors on which we don't plan on modifying the data