Fixes: https://github.com/vitorpamplona/amethyst/issues/740

Displays error messages when the URI sent to Amethyst is invalid

app/src/main/java/com/vitorpamplona/amethyst/ui/navigation/AppNavigation.kt

@@ -39,6 +39,7 @@ import androidx.core.util.Consumer
 import androidx.navigation.NavHostController
 import androidx.navigation.compose.NavHost
 import androidx.navigation.compose.composable
+import com.vitorpamplona.amethyst.R
 import com.vitorpamplona.amethyst.ui.MainActivity
 import com.vitorpamplona.amethyst.ui.note.UserReactionsViewModel
 import com.vitorpamplona.amethyst.ui.screen.NostrChatroomListKnownFeedViewModel
@@ -359,31 +360,60 @@ fun AppNavigation(
     }
 
     val activity = LocalContext.current.getActivity()
-    var actionableNextPage by remember {
+
-        mutableStateOf(uriToRoute(activity.intent?.data?.toString()?.ifBlank { null }))
+    var currentIntentNextPage by remember {
+        mutableStateOf(activity.intent?.data?.toString()?.ifBlank { null })
     }
-    actionableNextPage?.let {
+
-        LaunchedEffect(it) {
+    currentIntentNextPage?.let { intentNextPage ->
-            navController.navigate(it) {
+        var actionableNextPage by remember {
-                popUpTo(Route.Home.route)
+            mutableStateOf(uriToRoute(intentNextPage))
-                launchSingleTop = true
+        }
-            }
+
+        LaunchedEffect(intentNextPage) {
+            if (actionableNextPage != null) {
+                actionableNextPage?.let {
+                    navController.navigate(it) {
+                        popUpTo(Route.Home.route)
+                        launchSingleTop = true
+                    }
+                    actionableNextPage = null
+                }
+            } else {
+                accountViewModel.toast(
+                    R.string.invalid_nip19_uri,
+                    R.string.invalid_nip19_uri_description,
+                    intentNextPage,
+                )
+            }
+
+            currentIntentNextPage = null
         }
-        actionableNextPage = null
     }
 
     DisposableEffect(activity) {
         val consumer =
             Consumer<Intent> { intent ->
                 val uri = intent?.data?.toString()
-                val newPage = uriToRoute(uri)
+                if (!uri.isNullOrBlank()) {
+                    val newPage = uriToRoute(uri)
 
-                newPage?.let { route ->
+                    if (newPage != null) {
-                    val currentRoute = getRouteWithArguments(navController)
+                        val currentRoute = getRouteWithArguments(navController)
-                    if (!isSameRoute(currentRoute, route)) {
+                        if (!isSameRoute(currentRoute, newPage)) {
-                        navController.navigate(route) {
+                            navController.navigate(newPage) {
-                            popUpTo(Route.Home.route)
+                                popUpTo(Route.Home.route)
-                            launchSingleTop = true
+                                launchSingleTop = true
+                            }
+                        }
+                    } else {
+                        scope.launch {
+                            delay(1000)
+                            accountViewModel.toast(
+                                R.string.invalid_nip19_uri,
+                                R.string.invalid_nip19_uri_description,
+                                uri,
+                            )
                         }
                     }
                 }

app/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/AccountViewModel.kt

@@ -105,7 +105,11 @@ import kotlin.time.measureTimedValue
 
 @Immutable class StringToastMsg(val title: String, val msg: String) : ToastMsg()
 
-@Immutable class ResourceToastMsg(val titleResId: Int, val resourceId: Int) : ToastMsg()
+@Immutable class ResourceToastMsg(
+    val titleResId: Int,
+    val resourceId: Int,
+    val params: Array<out String>? = null,
+) : ToastMsg()
 
 @Stable
 class AccountViewModel(val account: Account, val settings: SettingsState) : ViewModel(), Dao {
@@ -141,6 +145,14 @@ class AccountViewModel(val account: Account, val settings: SettingsState) : View
         viewModelScope.launch { toasts.emit(ResourceToastMsg(titleResId, resourceId)) }
     }
 
+    fun toast(
+        titleResId: Int,
+        resourceId: Int,
+        vararg params: String,
+    ) {
+        viewModelScope.launch { toasts.emit(ResourceToastMsg(titleResId, resourceId, params)) }
+    }
+
     fun isWriteable(): Boolean {
         return account.isWriteable()
     }

app/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/MainScreen.kt

@@ -473,12 +473,22 @@ private fun DisplayErrorMessages(accountViewModel: AccountViewModel) {
     openDialogMsg.value?.let { obj ->
         when (obj) {
             is ResourceToastMsg ->
-                InformationDialog(
+                if (obj.params != null) {
-                    context.getString(obj.titleResId),
+                    InformationDialog(
-                    context.getString(obj.resourceId),
+                        context.getString(obj.titleResId),
-                ) {
+                        context.getString(obj.resourceId, *obj.params),
-                    accountViewModel.clearToasts()
+                    ) {
+                        accountViewModel.clearToasts()
+                    }
+                } else {
+                    InformationDialog(
+                        context.getString(obj.titleResId),
+                        context.getString(obj.resourceId),
+                    ) {
+                        accountViewModel.clearToasts()
+                    }
                 }
+
             is StringToastMsg ->
                 InformationDialog(
                     obj.title,

app/src/main/res/values/strings.xml

@@ -753,4 +753,7 @@
     <string name="add_content_warning">Add content warning</string>
     <string name="remove_content_warning">Remove content warning</string>
     <string name="show_npub_as_a_qr_code">Show npub as a QR code</string>
+
+    <string name="invalid_nip19_uri">Invalid address</string>
+    <string name="invalid_nip19_uri_description">Amethyst received a URI to open but that uri was invalid: %1$s</string>
 </resources>

quartz/src/main/java/com/vitorpamplona/quartz/encoders/Nip19.kt

@@ -97,7 +97,12 @@ object Nip19 {
                     "naddr1" -> naddr(bytes)
                     else -> null
                 }
-            parsed?.copy(additionalChars = additionalChars ?: "")
+
+            if (parsed?.hex?.isBlank() == true) {
+                null
+            } else {
+                parsed?.copy(additionalChars = additionalChars ?: "")
+            }
         } catch (e: Throwable) {
             Log.w("NIP19 Parser", "Issue trying to Decode NIP19 $key: ${e.message}", e)
             null