1
0
mirror of git://jb55.com/damus synced 2024-09-29 00:10:43 +00:00

ndb: fix crash with Ndb garbage collection on de-init

This commit is contained in:
William Casarin 2024-01-26 10:57:50 -08:00
parent bfb0dbac56
commit b80bab35b8

View File

@ -448,7 +448,17 @@ class Ndb {
}
deinit {
self.close()
//print("txn: Ndb de-init close")
//
// DO NOT CLOSE IN DESTRUCTOR! Destructor deinit is clearly
// not reliable, since it seems to be getting called more than
// once when we have a few references to the database.
//
// Not sure if this is indicitable of a larger problem but I've
// experienced nothing but hell when relying on de-init for
// global resources. Free them manually.
//
// EVIL --> self.close() <-- EVIL
}
}