1
0
mirror of git://jb55.com/damus synced 2024-09-29 00:10:43 +00:00
damus/damus.xcodeproj
Daniel D’Aquino 671b0b67ce Add playback controls to videos
This commit includes several UX changes to give users better control
over video playback. It also, by design, work arounds a SwiftUI quirk*

Here are the changes to the UX:

1. Videos on the feed only have a mute/unmute button
2. When the user clicks on the video, they are taken to a full screen carousel view (similar to when you click on an image)
3. The full-screen carousel view shows all video playback controls (through a specific SwiftUI hack)
4. If the carousel has multiple videos/images, the user can swipe between them normally as expected

Other UI changes that were made:

- The full screen carousel now uses dark mode (black background, white close button)

* The SwiftUI quirk is that when video views are placed within a TabView with ".page" tab view style, the tabview consumes most of the user gestures, making the video playback controls unusable.

Changelog-Changed: Improve UX around video playback
Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
Link: 20240318222048.14226-3-daniel@daquino.me
Signed-off-by: William Casarin <jb55@jb55.com>
2024-03-20 09:55:48 +00:00
..
project.xcworkspace test: Setup Snapshot testing library and add a snapshot test (testTextWrapperViewWillWrapText) 2023-10-10 22:05:45 -07:00
xcshareddata/xcschemes project: upgrade to recommended settings 2024-01-24 09:39:42 -08:00
project.pbxproj Add playback controls to videos 2024-03-20 09:55:48 +00:00