mirror of
git://jb55.com/damus
synced 2024-09-16 02:03:45 +00:00
a06be64894
This change addresses an issue where notes with quotes sometimes are not loaded correctly because the quoted note was not available in the same relay. Now whenever a user posts a note with a quoted note, the quoted note is also broadcast to the user's selected relays. Issue repro ----------- ISSUE REPRODUCED Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: `1fabd4c0fe98d1f47b1fa0f76984ad78095bd49c` Setup: - Make sure you have a debugger connected - Have a test note that you can quote Steps: 1. Start Damus and let logs settle 2. Observe where the last log is 3. Quote the test note 4. Copy newly generated logs and paste on a text editor. 5. Analyze those logs. Pay attention to the new note id, as well as the note id of the quoted event (`["q", <QUOTED_NOTE_ID>]`) Results: Logs show that the newly posted event is being flushed to the relays, but not the note that is being quoted. Testing of the fix ------------------ PASS Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: This commit Setup: - Make sure you have a debugger connected - Have a test note that you can quote Steps: 1. Start Damus and let logs settle 2. Observe where the last log is 3. Quote the test note 4. Copy newly generated logs and paste on a text editor. 5. Analyze those logs. Pay attention to the new note id, as well as the note id of the quoted event (`["q", <QUOTED_NOTE_ID>]`) Results: - Logs show the new event being flushed to the relays. PASS - Logs show the quoted event also being flushed to the relays. PASS Closes: https://github.com/damus-io/damus/issues/1495 Changelog-Fixed: Broadcast quoted notes when posting a note with quotes Signed-off-by: Daniel D’Aquino <daniel@daquino.me> Reviewed-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com> |
||
|---|---|---|
| .. | ||
| bindings | ||
| flatcc | ||
| Test | ||
| AsciiCharacter.swift | ||
| copy-ndb | ||
| jsmn.h | ||
| lmdb.h | ||
| mdb.c | ||
| memchr.h | ||
| midl.c | ||
| midl.h | ||
| Ndb.swift | ||
| NdbNote.swift | ||
| NdbTagElem.swift | ||
| NdbTagIterator.swift | ||
| NdbTagsIterator.swift | ||
| NdbTxn.swift | ||
| nostrdb.c | ||
| nostrdb.h | ||
| protected_queue.h | ||
| random.h | ||
| secp256k1_ecdh.h | ||
| secp256k1_extrakeys.h | ||
| secp256k1_schnorrsig.h | ||
| secp256k1.h | ||
| threadpool.h | ||
| util.h | ||