mirror of
git://jb55.com/damus
synced 2024-09-05 21:03:51 +00:00
a1e6be214e
This change was made so that NostrDB data can be accessed from different build targets such as the notification service extension. Upon initialization of NostrDB, it will check both DB file locations (the old documents directory, and the new shared app group container). If it sees the DB is present on the old location, and not on the new location, it will move the files to the new location. In any other condition it will keep the files intact to prevent data loss. In order to avoid any conflicts between the damusApp's Ndb instance and the extension's Ndb instance when writing or moving the file, a new parameter called "owns_db_file" was added, and set to "false" for the extension. This ensures that the extension will not attempt to move DB files or create a new DB file on its own. Only the main app can move or create the DB file. Testing ------- PASS Device: iPhone 15 Pro simulator iOS: 17.0.1 Damus: This commit Steps: 1. Run with the debugger attached to the extension target. 2. Using Apple's push notification testing dashboard, send a test push notification with a real payload (that includes the nostr event under `nostr_event`. Payload generated by strfry-push-notify). 3. Watch logs. It should show a message like "Got push notification from <DISPLAY_NAME>", where `DISPLAY_NAME` is the correct profile name of the user who generated the event. PASS Regression testing ------------------ Device: iPhone 13 Mini (Real device) iOS: 17.1.1 Damus: This commit Other preconditions: - Damus is at 1.6 (29) at the start of the test - NostrDB filled with real data on the old location Steps: 1. Flash (upgrade) the new Damus version (this commit) (This will be the first time upgrading, shared file container is empty) 2. Try to use the app normally. Scroll and navigate to several locations. Interact with some notes. App should be stable, work, and appear to have profile names already (i.e. It shouldn't start with a bunch of npubs in the place of profile names on known contacts). PASS 3. Downgrade back to the App store version (v1.6 (29)) 4. Try to use the app normally. Scroll and navigate, interact, etc. App should work and be stable, but profile name cache is expected to be lost (i.e. shows npubs for a bit until profile is reloaded into NostrDB). PASS 5. Upgrade app again to the version in this commit. 6. Repeat step 2. Everything should work as normal and all profiles should be preloaded from the start. PASS Closes: https://github.com/damus-io/damus/issues/1744 |
||
|---|---|---|
| .. | ||
| project.xcworkspace | ||
| xcshareddata/xcschemes | ||
| project.pbxproj | ||