Deprecate creating relationships Bookmarks and Curates (which aren't easily workable as relationships)

gossip-lib/src/process.rs

@@ -697,6 +697,13 @@ pub(crate) fn process_relationships_of_event<'a>(
             }
         }
 
+        /*
+        Bookmarks as relationships don't work well because it is
+        expensive to clear all relationships that are bookmarks
+        when rewriting them to match a new bookmark list event.
+        So we are retiring creating this relationships (and may
+        delete them later)
+
         // ListBookmarks
         if event.kind == EventKind::BookmarkList {
             for tag in &event.tags {
@@ -765,6 +772,8 @@ pub(crate) fn process_relationships_of_event<'a>(
             }
         }
 
+         */
+
         if event.kind == EventKind::LiveChatMessage {
             for tag in &event.tags {
                 if let Ok((ea, _marker)) = tag.parse_address() {

gossip-lib/src/storage/types/relationship_by_id2.rs

@@ -36,9 +36,11 @@ pub enum RelationshipById2 {
     Pins,
 
     // NIP-51 Lists
+    // @deprecatred, doesn't work well as a relationship
     Bookmarks,
 
     // NIP-51 Lists
+    // @deprecatred, doesn't work well as a relationship
     Curates,
 
     // NIP-56 Reporting