Revert renaming "as_reply_to" in outer code where it only has that meaning. It's still called "hide_footer" in render_note_inner() because there, there is now more than one reason to hide the footer.

This commit is contained in:
bu5hm4nn 2023-03-21 23:38:53 -06:00
parent 5a202195cd
commit ba2df1663f
3 changed files with 12 additions and 12 deletions

View File

@ -13,7 +13,7 @@ mod post;
struct FeedNoteParams {
id: Id,
indent: usize,
hide_footer: bool,
as_reply_to: bool,
threaded: bool,
is_first: bool,
is_last: bool,
@ -174,7 +174,7 @@ fn render_a_feed(
FeedNoteParams {
id: *id,
indent: 0,
hide_footer: false,
as_reply_to: false,
threaded,
is_first: Some(id) == first,
is_last: Some(id) == last,
@ -195,7 +195,7 @@ fn render_note_maybe_fake(
let FeedNoteParams {
id,
indent,
hide_footer,
as_reply_to,
threaded,
is_first,
is_last,
@ -234,7 +234,7 @@ fn render_note_maybe_fake(
FeedNoteParams {
id,
indent,
hide_footer,
as_reply_to,
threaded,
is_first,
is_last,
@ -251,7 +251,7 @@ fn render_note_maybe_fake(
ui.add_space(height);
// Yes, and we need to fake render threads to get their approx height too.
if threaded && !hide_footer {
if threaded && !as_reply_to {
let replies = Globals::get_replies_sync(event.id);
let iter = replies.iter();
let first = replies.first();
@ -265,7 +265,7 @@ fn render_note_maybe_fake(
FeedNoteParams {
id: *reply_id,
indent: indent + 1,
hide_footer,
as_reply_to,
threaded,
is_first: Some(reply_id) == first,
is_last: Some(reply_id) == last,
@ -282,7 +282,7 @@ fn render_note_maybe_fake(
FeedNoteParams {
id,
indent,
hide_footer,
as_reply_to,
threaded,
is_first,
is_last,

View File

@ -189,7 +189,7 @@ pub(super) fn render_note(
let FeedNoteParams {
id,
indent,
hide_footer,
as_reply_to,
threaded,
is_first,
is_last,
@ -258,7 +258,7 @@ pub(super) fn render_note(
if note_data.author.muted > 0 {
ui.label(RichText::new("MUTED POST").monospace().italics());
} else {
render_note_inner(app, ctx, ui, note_data, &render_data, hide_footer, &None);
render_note_inner(app, ctx, ui, note_data, &render_data, as_reply_to, &None);
}
});
});
@ -279,7 +279,7 @@ pub(super) fn render_note(
app.settings.theme.feed_post_separator_stroke(&render_data),
);
if threaded && !hide_footer {
if threaded && !as_reply_to {
let replies = Globals::get_replies_sync(id);
let iter = replies.iter();
let first = replies.first();
@ -293,7 +293,7 @@ pub(super) fn render_note(
FeedNoteParams {
id: *reply_id,
indent: indent + 1,
hide_footer,
as_reply_to,
threaded,
is_first: Some(reply_id) == first,
is_last: Some(reply_id) == last,

View File

@ -99,7 +99,7 @@ fn real_posting_area(app: &mut GossipUi, ctx: &Context, frame: &mut eframe::Fram
FeedNoteParams {
id,
indent: 0,
hide_footer: true,
as_reply_to: true,
threaded: false,
is_first: true,
is_last: true,