From 416dc66621849b0369b28785fa3b1beaefdc17d6 Mon Sep 17 00:00:00 2001
From: Alejandro Gomez <alejandro@strike.me>
Date: Fri, 6 Jan 2023 12:05:27 +0100
Subject: [PATCH] feat: clickable links on about page

---
 src/Text.js              | 88 ++++++++++++++++++++++++++++++++++++++++
 src/element/Note.js      | 88 +---------------------------------------
 src/pages/ProfilePage.js |  3 +-
 3 files changed, 92 insertions(+), 87 deletions(-)
 create mode 100644 src/Text.js

diff --git a/src/Text.js b/src/Text.js
new file mode 100644
index 000000000..7b8687322
--- /dev/null
+++ b/src/Text.js
@@ -0,0 +1,88 @@
+import { Link } from "react-router-dom";
+
+import Invoice from "./element/Invoice";
+import { UrlRegex, FileExtensionRegex, MentionRegex, InvoiceRegex } from "./Const";
+
+export function extractLinks(fragments) {
+    return fragments.map(f => {
+        if (typeof f === "string") {
+            return f.split(UrlRegex).map(a => {
+                if (a.startsWith("http")) {
+                    try {
+                        let url = new URL(a);
+                        let ext = url.pathname.toLowerCase().match(FileExtensionRegex);
+                        if (ext) {
+                            switch (ext[1]) {
+                                case "gif":
+                                case "jpg":
+                                case "jpeg":
+                                case "png":
+                                case "bmp":
+                                case "webp": {
+                                    return <img key={url} src={url} />;
+                                }
+                                case "mp4":
+                                case "mkv":
+                                case "avi":
+                                case "m4v": {
+                                    return <video key={url} src={url} controls />
+                                }
+                            }
+                        } else {
+                            return <a href={url}>{url.toString()}</a>
+                        }
+                    } catch (e) {
+                        console.warn(`Not a valid url: ${a}`);
+                    }
+                }
+                return a;
+            });
+        }
+        return f;
+    }).flat();
+}
+
+export function extractMentions(fragments, tags, users) {
+    return fragments.map(f => {
+        if (typeof f === "string") {
+            return f.split(MentionRegex).map((match) => {
+                let matchTag = match.match(/#\[(\d+)\]/);
+                if (matchTag && matchTag.length === 2) {
+                    let idx = parseInt(matchTag[1]);
+                    let ref = tags.find(a => a.Index === idx);
+                    if (ref) {
+                        switch (ref.Key) {
+                            case "p": {
+                                let pUser = users[ref.PubKey]?.name ?? ref.PubKey.substring(0, 8);
+                                return <Link key={ref.PubKey} to={`/p/${ref.PubKey}`}>@{pUser}</Link>;
+                            }
+                            case "e": {
+                                let eText = ref.Event.substring(0, 8);
+                                return <Link key={ref.Event} to={`/e/${ref.Event}`}>#{eText}</Link>;
+                            }
+                        }
+                    }
+                    return <b style={{ color: "red" }}>{matchTag[0]}?</b>;
+                } else {
+                    return match;
+                }
+            });
+        }
+        return f;
+    }).flat();
+}
+
+export function extractInvoices(fragments) {
+    return fragments.map(f => {
+        if (typeof f === "string") {
+            return f.split(InvoiceRegex).map(i => {
+                if (i.toLowerCase().startsWith("lnbc")) {
+                    return <Invoice key={i} invoice={i} />
+                } else {
+                    return i;
+                }
+            });
+        }
+        return f;
+    }).flat();
+}
diff --git a/src/element/Note.js b/src/element/Note.js
index 3e5829e4d..248cd1284 100644
--- a/src/element/Note.js
+++ b/src/element/Note.js
@@ -11,7 +11,7 @@ import ProfileImage from "./ProfileImage";
 import useEventPublisher from "../feed/EventPublisher";
 import { NoteCreator } from "./NoteCreator";
 import Invoice from "./Invoice";
-import { UrlRegex, FileExtensionRegex, MentionRegex, InvoiceRegex } from "../Const";
+import { extractLinks, extractMentions, extractInvoices } from "../Text";
 
 export default function Note(props) {
     const navigate = useNavigate();
@@ -38,7 +38,7 @@ export default function Note(props) {
         let body = ev?.Content ?? "";
 
         let fragments = extractLinks([body]);
-        fragments = extractMentions(fragments);
+        fragments = extractMentions(fragments, ev.Tags, users);
         fragments = extractInvoices(fragments);
         if (deletion?.length > 0) {
             return (
@@ -72,90 +72,6 @@ export default function Note(props) {
         )
     }
 
-    function extractInvoices(fragments) {
-        return fragments.map(f => {
-            if (typeof f === "string") {
-                return f.split(InvoiceRegex).map(i => {
-                    if (i.toLowerCase().startsWith("lnbc")) {
-                        return <Invoice key={i} invoice={i} />
-                    } else {
-                        return i;
-                    }
-                });
-            }
-            return f;
-        }).flat();
-    }
-
-    function extractMentions(fragments) {
-        return fragments.map(f => {
-            if (typeof f === "string") {
-                return f.split(MentionRegex).map((match) => {
-                    let matchTag = match.match(/#\[(\d+)\]/);
-                    if (matchTag && matchTag.length === 2) {
-                        let idx = parseInt(matchTag[1]);
-                        let ref = ev.Tags.find(a => a.Index === idx);
-                        if (ref) {
-                            switch (ref.Key) {
-                                case "p": {
-                                    let pUser = users[ref.PubKey]?.name ?? ref.PubKey.substring(0, 8);
-                                    return <Link key={ref.PubKey} to={`/p/${ref.PubKey}`}>@{pUser}</Link>;
-                                }
-                                case "e": {
-                                    let eText = ref.Event.substring(0, 8);
-                                    return <Link key={ref.Event} to={`/e/${ref.Event}`}>#{eText}</Link>;
-                                }
-                            }
-                        }
-                        return <b style={{ color: "red" }}>{matchTag[0]}?</b>;
-                    } else {
-                        return match;
-                    }
-                });
-            }
-            return f;
-        }).flat();
-    }
-
-    function extractLinks(fragments) {
-        return fragments.map(f => {
-            if (typeof f === "string") {
-                return f.split(UrlRegex).map(a => {
-                    if (a.startsWith("http")) {
-                        try {
-                            let url = new URL(a);
-                            let ext = url.pathname.toLowerCase().match(FileExtensionRegex);
-                            if (ext) {
-                                switch (ext[1]) {
-                                    case "gif":
-                                    case "jpg":
-                                    case "jpeg":
-                                    case "png":
-                                    case "bmp":
-                                    case "webp": {
-                                        return <img key={url} src={url} />;
-                                    }
-                                    case "mp4":
-                                    case "mkv":
-                                    case "avi":
-                                    case "m4v": {
-                                        return <video key={url} src={url} controls />
-                                    }
-                                }
-                            } else {
-                                return <a href={url}>{url.toString()}</a>
-                            }
-                        } catch (e) {
-                            console.warn(`Not a valid url: ${a}`);
-                        }
-                    }
-                    return a;
-                });
-            }
-            return f;
-        }).flat();
-    }
-
     async function like() {
         let evLike = await publisher.like(ev);
         publisher.broadcast(evLike);
diff --git a/src/pages/ProfilePage.js b/src/pages/ProfilePage.js
index 39a709888..fbf898443 100644
--- a/src/pages/ProfilePage.js
+++ b/src/pages/ProfilePage.js
@@ -17,6 +17,7 @@ import FollowButton from "../element/FollowButton";
 import VoidUpload from "../feed/VoidUpload";
 import { openFile } from "../Util";
 import Timeline from "../element/Timeline";
+import { extractLinks } from '../Text'
 
 export default function ProfilePage() {
     const dispatch = useDispatch();
@@ -177,7 +178,7 @@ export default function ProfilePage() {
                         <FollowButton pubkey={id} />
                     </div>
                 </div>
-                <p>{about}</p>
+                <p>{extractLinks([about])}</p>
                 {website ? <a href={website} target="_blank" rel="noreferrer">{website}</a> : null}
 
                 {lud16 ? <div className="flex">