finishing touches

This commit is contained in:
ennmichael 2023-02-27 00:25:11 +01:00
parent fe45cb4beb
commit 289dbcd523
No known key found for this signature in database
GPG Key ID: 6E6E183431A26AF7
3 changed files with 4 additions and 4 deletions

View File

@ -1,2 +0,0 @@
- Don't use arrays for callbacks because there's no way to clear them,
passing undefined or null to on* should clear the callback

View File

@ -49,7 +49,9 @@ export class Conn {
if (err instanceof ProtocolError) { if (err instanceof ProtocolError) {
this.#errorCallback?.(err) this.#errorCallback?.(err)
} else { } else {
// TODO Not sure if this is the case? // TODO Not sure if this is the best idea.
// Investigate what WebSocket does if the callback throws?
// Either way it seems like the best idea is to have `onError` called on all types of errors
throw err throw err
} }
} }

View File

@ -226,7 +226,7 @@ interface ConnState {
*/ */
auth: boolean auth: boolean
/** /**
* Should this connection be used for receiving messages? * Should this connection be used for receiving events?
*/ */
read: boolean read: boolean
/** /**