chore: cleanup warnings

src/Element/Nip5Service.tsx

@@ -33,7 +33,7 @@ export default function Nip5Service(props: Nip05ServiceProps) {
     const pubkey = useSelector<ReduxStore, string>(s => s.login.publicKey);
     const user = useProfile(pubkey);
     const publisher = useEventPublisher();
-    const svc = new ServiceProvider(props.service);
+    const svc = useMemo(() => new ServiceProvider(props.service), [props.service]);
     const [serviceConfig, setServiceConfig] = useState<ServiceConfig>();
     const [error, setError] = useState<ServiceError>();
     const [handle, setHandle] = useState<string>("");
@@ -43,7 +43,7 @@ export default function Nip5Service(props: Nip05ServiceProps) {
     const [showInvoice, setShowInvoice] = useState<boolean>(false);
     const [registerStatus, setRegisterStatus] = useState<CheckRegisterResponse>();
 
-    const domainConfig = useMemo(() => serviceConfig?.domains.find(a => a.name === domain), [domain]);
+    const domainConfig = useMemo(() => serviceConfig?.domains.find(a => a.name === domain), [domain, serviceConfig]);
 
     useEffect(() => {
         svc.GetConfig()
@@ -58,7 +58,7 @@ export default function Nip5Service(props: Nip05ServiceProps) {
                 }
             })
             .catch(console.error)
-    }, [props]);
+    }, [props, svc]);
 
     useEffect(() => {
         setError(undefined);
@@ -89,7 +89,7 @@ export default function Nip5Service(props: Nip05ServiceProps) {
                     .catch(console.error);
             });
         }
-    }, [handle, domain]);
+    }, [handle, domain, domainConfig, svc]);
 
     useEffect(() => {
         if (registerResponse && showInvoice) {
@@ -111,7 +111,7 @@ export default function Nip5Service(props: Nip05ServiceProps) {
             }, 2_000);
             return () => clearInterval(t);
         }
-    }, [registerResponse, showInvoice])
+    }, [registerResponse, showInvoice, svc])
 
     function mapError(e: ServiceErrorCode, t: string | null): string | undefined {
         let whyMap = new Map([

src/Element/NoteCreator.css

@@ -16,13 +16,8 @@
     min-height: 40px;
     background-color: var(--note-bg);
     border-radius: 10px 10px 0 0;
-    max-width: -webkit-fill-available;
+    max-width: stretch;
-    max-width: -moz-available;
+    min-width: stretch;
-    max-width: fill-available;
-    min-width: 100%;
-    min-width: -webkit-fill-available;
-    min-width: -moz-available;
-    min-width: fill-available;
 }
 
 .note-creator .actions {

src/Element/NoteFooter.tsx

@@ -31,8 +31,8 @@ export default function NoteFooter(props: NoteFooterProps) {
   const [reply, setReply] = useState(false);
   const [tip, setTip] = useState(false);
   const isMine = ev.RootPubKey === login;
-  const reactions = useMemo(() => getReactions(related, ev.Id, EventKind.Reaction), [related]);
+  const reactions = useMemo(() => getReactions(related, ev.Id, EventKind.Reaction), [related, ev]);
-  const reposts = useMemo(() => getReactions(related, ev.Id, EventKind.Repost), [related]);
+  const reposts = useMemo(() => getReactions(related, ev.Id, EventKind.Repost), [related, ev]);
   const groupReactions = useMemo(() => {
     return reactions?.reduce((acc, { content }) => {
       let r = normalizeReaction(content);

src/Element/NoteReaction.tsx

@@ -16,7 +16,8 @@ export interface NoteReactionProps {
     root?: TaggedRawEvent
 }
 export default function NoteReaction(props: NoteReactionProps) {
-    const ev = useMemo(() => props["data-ev"] || new NEvent(props.data), [props.data, props["data-ev"]])
+    const { ["data-ev"]: dataEv, data } = props;
+    const ev = useMemo(() => dataEv || new NEvent(data), [data, dataEv])
 
     const refEvent = useMemo(() => {
         if (ev) {
@@ -32,19 +33,6 @@ export default function NoteReaction(props: NoteReactionProps) {
         return null;
     }
 
-    function mapReaction(c: string) {
-        switch (c) {
-            case "+": return "❤️";
-            case "-": return "👎";
-            default: {
-                if (c.length === 0) {
-                    return "❤️";
-                }
-                return c;
-            }
-        }
-    }
-
     /**
      * Some clients embed the reposted note in the content
      */

src/Element/Relay.tsx

@@ -1,11 +1,11 @@
 import "./Relay.css"
 
-import { faPlug, faTrash, faSquareCheck, faSquareXmark, faWifi, faPlugCircleXmark, faGear } from "@fortawesome/free-solid-svg-icons";
+import { faPlug, faSquareCheck, faSquareXmark, faWifi, faPlugCircleXmark, faGear } from "@fortawesome/free-solid-svg-icons";
 import useRelayState from "Feed/RelayState";
 import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
-import { useMemo, useState } from "react";
+import { useMemo } from "react";
 import { useDispatch, useSelector } from "react-redux";
-import { removeRelay, setRelays } from "State/Login";
+import { setRelays } from "State/Login";
 import { RootState } from "State/Store";
 import { RelaySettings } from "Nostr/Connection";
 import { useNavigate } from "react-router-dom";

src/Element/Timeline.tsx

@@ -1,5 +1,5 @@
 import "./Timeline.css";
-import { useMemo } from "react";
+import { useCallback, useMemo } from "react";
 import useTimelineFeed, { TimelineSubject } from "Feed/TimelineFeed";
 import { TaggedRawEvent } from "Nostr";
 import EventKind from "Nostr/EventKind";
@@ -23,17 +23,17 @@ export default function Timeline({ subject, postsOnly = false, method }: Timelin
         method
     });
 
-    const filterPosts = (notes: TaggedRawEvent[]) => {
+    const filterPosts = useCallback((nts: TaggedRawEvent[]) => {
-        return [...notes].sort((a, b) => b.created_at - a.created_at)?.filter(a => postsOnly ? !a.tags.some(b => b[0] === "e") : true);
+        return [...nts].sort((a, b) => b.created_at - a.created_at)?.filter(a => postsOnly ? !a.tags.some(b => b[0] === "e") : true);
-    }
+    }, [postsOnly]);
 
     const mainFeed = useMemo(() => {
         return filterPosts(main.notes);
-    }, [main]);
+    }, [main, filterPosts]);
 
     const latestFeed = useMemo(() => {
         return filterPosts(latest.notes).filter(a => !mainFeed.some(b => b.id === a.id));
-    }, [latest]);
+    }, [latest, mainFeed, filterPosts]);
 
     function eventElement(e: TaggedRawEvent) {
         switch (e.kind) {

src/Feed/ProfileFeed.ts

@@ -1,5 +1,5 @@
 import { useLiveQuery } from "dexie-react-hooks";
-import { useEffect, useMemo } from "react";
+import { useEffect } from "react";
 import { db } from "Db";
 import { MetadataCache } from "Db/User";
 import { HexKey } from "Nostr";

src/Feed/Subscription.ts

@@ -38,7 +38,8 @@ function notesReducer(state: NoteStore, arg: ReducerArg) {
     if (!Array.isArray(evs)) {
         evs = [evs];
     }
-    evs = evs.filter(a => !state.notes.some(b => b.id === a.id));
+    let existingIds = new Set(state.notes.map(a => a.id));
+    evs = evs.filter(a => !existingIds.has(a.id));
     if (evs.length === 0) {
         return state;
     }
@@ -83,7 +84,7 @@ export default function useSubscription(sub: Subscriptions | null, options?: Use
                 setSubDebounced(sub);
             });
         }
-    }, [sub]);
+    }, [sub, options]);
 
     useEffect(() => {
         if (sub) {
@@ -115,6 +116,7 @@ export default function useSubscription(sub: Subscriptions | null, options?: Use
             };
         }
     }, [subDebounce]);
+
     useEffect(() => {
         return debounce(DebounceMs, () => {
             setDebounceOutput(s => s += 1);

src/Feed/ThreadFeed.ts

@@ -36,7 +36,7 @@ export default function useThreadFeed(id: u256) {
         thisSub.AddSubscription(subRelated);
 
         return thisSub;
-    }, [trackingEvents]);
+    }, [trackingEvents, pref, id]);
 
     const main = useSubscription(sub, { leaveOpen: true });
 

src/Feed/TimelineFeed.ts

@@ -1,4 +1,4 @@
-import { useEffect, useMemo, useState } from "react";
+import { useCallback, useEffect, useMemo, useState } from "react";
 import { u256 } from "Nostr";
 import EventKind from "Nostr/EventKind";
 import { Subscriptions } from "Nostr/Subscriptions";
@@ -19,15 +19,15 @@ export interface TimelineSubject {
 
 export default function useTimelineFeed(subject: TimelineSubject, options: TimelineFeedOptions) {
     const now = unixNow();
-    const [window, setWindow] = useState<number>(60 * 60);
+    const [window] = useState<number>(60 * 60);
     const [until, setUntil] = useState<number>(now);
     const [since, setSince] = useState<number>(now - window);
     const [trackingEvents, setTrackingEvent] = useState<u256[]>([]);
     const [trackingParentEvents, setTrackingParentEvents] = useState<u256[]>([]);
     const pref = useSelector<RootState, UserPreferences>(s => s.login.preferences);
 
-    function createSub() {
+    const createSub = useCallback(() => {
-        if (subject.type !== "global" && subject.items.length == 0) {
+        if (subject.type !== "global" && subject.items.length === 0) {
             return null;
         }
 
@@ -49,7 +49,7 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
             }
         }
         return sub;
-    }
+    }, [subject.type, subject.items]);
 
     const sub = useMemo(() => {
         let sub = createSub();
@@ -78,7 +78,7 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
             }
         }
         return sub;
-    }, [subject.type, subject.items, until, since, window]);
+    }, [until, since, options.method, pref, createSub]);
 
     const main = useSubscription(sub, { leaveOpen: true });
 
@@ -90,7 +90,7 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
             subLatest.Since = Math.floor(new Date().getTime() / 1000);
         }
         return subLatest;
-    }, [subject.type, subject.items]);
+    }, [pref, createSub]);
 
     const latest = useSubscription(subRealtime, { leaveOpen: true });
 
@@ -103,7 +103,7 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
             sub.ETags = new Set(trackingEvents);
         }
         return sub ?? null;
-    }, [trackingEvents]);
+    }, [trackingEvents, pref, subject.type]);
 
     const others = useSubscription(subNext, { leaveOpen: true });
 
@@ -115,7 +115,7 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
             return parents;
         }
         return null;
-    }, [trackingParentEvents]);
+    }, [trackingParentEvents, subject.type]);
 
     const parent = useSubscription(subParents);
 
@@ -123,8 +123,10 @@ export default function useTimelineFeed(subject: TimelineSubject, options: Timel
         if (main.store.notes.length > 0) {
             setTrackingEvent(s => {
                 let ids = main.store.notes.map(a => a.id);
-                let temp = new Set([...s, ...ids]);
+                if(ids.some(a => !s.includes(a))) {
-                return Array.from(temp);
+                    return Array.from(new Set([...s, ...ids]));
+                }
+                return s;
             });
             let reposts = main.store.notes
                 .filter(a => a.kind === EventKind.Repost && a.content === "")

src/Nostr/Connection.ts

@@ -59,7 +59,7 @@ export default class Connection {
         this.Stats = new ConnectionStats();
         this.StateHooks = new Map();
         this.HasStateChange = true;
-        this.CurrentState = <StateSnapshot>{
+        this.CurrentState = {
             connected: false,
             disconnects: 0,
             avgLatency: 0,
@@ -67,7 +67,7 @@ export default class Connection {
                 received: 0,
                 send: 0
             }
-        };
+        } as StateSnapshot;
         this.LastState = Object.freeze({ ...this.CurrentState });
         this.IsClosed = false;
         this.ReconnectTimer = null;

src/Pages/NewUserPage.tsx

@@ -24,7 +24,7 @@ export default function NewUserPage() {
     const sortedTwitterFollows = useMemo(() => {
         return follows.map(a => bech32ToHex(a))
             .sort((a, b) => currentFollows.includes(a) ? 1 : -1);
-    }, [follows]);
+    }, [follows, currentFollows]);
 
     async function loadFollows() {
         setFollows([]);

src/Pages/settings/Profile.tsx

@@ -31,7 +31,6 @@ export default function ProfileSettings() {
     const [about, setAbout] = useState<string>();
     const [website, setWebsite] = useState<string>();
     const [nip05, setNip05] = useState<string>();
-    const [lud06, setLud06] = useState<string>();
     const [lud16, setLud16] = useState<string>();
 
     const avatarPicture = (picture?.length ?? 0) === 0 ? Nostrich : picture
@@ -45,7 +44,6 @@ export default function ProfileSettings() {
             setAbout(user.about);
             setWebsite(user.website);
             setNip05(user.nip05);
-            setLud06(user.lud06);
             setLud16(user.lud16);
         }
     }, [user]);

src/State/Login.ts

@@ -1,9 +1,8 @@
 import { createSlice, PayloadAction } from '@reduxjs/toolkit'
 import * as secp from '@noble/secp256k1';
 import { DefaultRelays } from 'Const';
-import { HexKey, RawEvent, TaggedRawEvent } from 'Nostr';
+import { HexKey, TaggedRawEvent } from 'Nostr';
 import { RelaySettings } from 'Nostr/Connection';
-import { useDispatch } from 'react-redux';
 
 const PrivateKeyItem = "secret";
 const PublicKeyItem = "pubkey";
@@ -182,7 +181,7 @@ const LoginSlice = createSlice({
             let filtered = new Map<string, RelaySettings>();
             for (let [k, v] of Object.entries(relays)) {
                 if (k.startsWith("wss://") || k.startsWith("ws://")) {
-                    filtered.set(k, <RelaySettings>v);
+                    filtered.set(k, v as RelaySettings);
                 }
             }
 

src/Util.ts

@@ -1,6 +1,6 @@
 import * as secp from "@noble/secp256k1";
 import { bech32 } from "bech32";
-import { HexKey, RawEvent, TaggedRawEvent, u256 } from "Nostr";
+import { HexKey, TaggedRawEvent, u256 } from "Nostr";
 import EventKind from "Nostr/EventKind";
 
 export async function openFile(): Promise<File | undefined> {
@@ -65,7 +65,7 @@ export function eventLink(hex: u256) {
  * @param {string} hex
  */
 export function hexToBech32(hrp: string, hex: string) {
-    if (typeof hex !== "string" || hex.length === 0 || hex.length % 2 != 0) {
+    if (typeof hex !== "string" || hex.length === 0 || hex.length % 2 !== 0) {
         return "";
     }
 

src/index.css

@@ -228,16 +228,12 @@ textarea:placeholder {
 
 .w-max {
   width: 100%;
-  width: -moz-available;
+  width: stretch;
-  width: -webkit-fill-available;
-  width: fill-available;
 }
 
 .w-max-w {
   max-width: 100%;
-  max-width: -moz-available;
+  max-width: stretch;
-  max-width: -webkit-fill-available;
-  max-width: fill-available;
 }
 
 a {
@@ -267,7 +263,7 @@ div.form-group>div:nth-child(1) {
 div.form-group>div:nth-child(2) {
   display: flex;
   flex-grow: 1;
-  justify-content: end;
+  justify-content: flex-end;
 }
 
 div.form-group>div:nth-child(2) input {