Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

Threads #170

Merged
verbiricha merged 41 commits from threads into main 2023-02-06 21:42:47 +00:00
Conversation 7 Commits 41 Files Changed 33 +842 -311
verbiricha commented 2023-01-30 10:06:23 +00:00 (Migrated from github.com)
Copy Link
No description provided.
cloudflare-pages[bot] commented 2023-01-30 10:07:50 +00:00 (Migrated from github.com)
Copy Link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c92c595
Status: ✅  Deploy successful!
Preview URL: https://a2b7e01c.snort-social.pages.dev
Branch Preview URL: https://threads.snort-social.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>c92c595</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://a2b7e01c.snort-social.pages.dev'>https://a2b7e01c.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://threads.snort-social.pages.dev'>https://threads.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/a2b7e01c-cd16-4a77-a0ad-6b61286a56d5)
verbiricha commented 2023-02-01 10:02:14 +00:00 (Migrated from github.com)
Copy Link

I'm going to tackle URL navigation separately, this can be reviewed already.

I'm going to tackle URL navigation separately, this can be reviewed already.
v0l commented 2023-02-02 09:17:31 +00:00 (Migrated from github.com)
Copy Link

Soem threads are hidden, maybe if im clicking into a note which is on 3rd level or deeper then it only shows the root and the note i click on is hidden somewhere:

https://threads.snort-social.pages.dev/e/note1ucc2nvd0ta9xqxjje6rmqkds745hyeglv4hv0c0xvfac2yzs656sjcn06r

Soem threads are hidden, maybe if im clicking into a note which is on 3rd level or deeper then it only shows the root and the note i click on is hidden somewhere: https://threads.snort-social.pages.dev/e/note1ucc2nvd0ta9xqxjje6rmqkds745hyeglv4hv0c0xvfac2yzs656sjcn06r
👍 1
v0l (Migrated from github.com) reviewed 2023-02-02 09:18:35 +00:00
src/Element/BackButton.tsx
@ -2,4 +2,2 @@
import { useNavigate } from "react-router-dom";
import ArrowBack from "Icons/ArrowBack";
v0l (Migrated from github.com) commented 2023-02-01 10:59:44 +00:00
Copy Link

If you open snort with no history the back button does nothing

If you open snort with no history the back button does nothing
src/Element/Note.tsx
@ -141,14 +142,17 @@ export default function Note(props: NoteProps) {
const others = mentions.length > maxMentions ? ` & ${othersLength} other${othersLength > 1 ? 's' : ''}` : ''
v0l (Migrated from github.com) commented 2023-02-01 11:01:36 +00:00
Copy Link

eventLink

`eventLink`
v0l commented 2023-02-03 13:37:00 +00:00 (Migrated from github.com)
Copy Link

Its still hiding this note, if i go to https://threads.snort-social.pages.dev/e/note1ucc2nvd0ta9xqxjje6rmqkds745hyeglv4hv0c0xvfac2yzs656sjcn06r it should show this note as focus? Right now i have to expand the Show more and there is no indication that its the selected note

Its still hiding this note, if i go to https://threads.snort-social.pages.dev/e/note1ucc2nvd0ta9xqxjje6rmqkds745hyeglv4hv0c0xvfac2yzs656sjcn06r it should show this note as focus? Right now i have to expand the Show more and there is no indication that its the selected note
verbiricha commented 2023-02-03 15:03:29 +00:00 (Migrated from github.com)
Copy Link

@v0l my bad, accidentaly removed the highlight. Added it back, also expand subthreads when active is there.

@v0l my bad, accidentaly removed the highlight. Added it back, also expand subthreads when active is there.
v0l commented 2023-02-05 12:17:40 +00:00 (Migrated from github.com)
Copy Link

Seems to not work still, when i navigate to post in a thread its highlighted at first but when the rest of the thread is loaded its buried

Instead of rendering the full thread we should skip to the level that the post is on and hide the upper levels?

Seems to not work still, when i navigate to post in a thread its highlighted at first but when the rest of the thread is loaded its buried Instead of rendering the full thread we should skip to the level that the post is on and hide the upper levels?
👀 1
verbiricha commented 2023-02-06 16:06:22 +00:00 (Migrated from github.com)
Copy Link

@v0l can you take another 👀 ?

@v0l can you take another 👀 ?
v0l (Migrated from github.com) approved these changes 2023-02-06 21:28:17 +00:00
v0l (Migrated from github.com) left a comment
Copy Link

❤️

❤️
Sign in to join this conversation.
Reviewers
No reviewers
v0l
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#170
No description provided.
Delete Branch "threads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?