Kieran
/
snort
5
14
Fork 14
Code Issues 53 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

Zap modal #209

Merged
verbiricha merged 7 commits from zap-modal into main 2023-02-07 13:32:33 +00:00
Conversation 11 Commits 7 Files Changed 18 +403 -159
verbiricha commented 2023-02-07 11:03:21 +00:00 (Migrated from github.com)
Copy Link
No description provided.
v0l (Migrated from github.com) reviewed 2023-02-07 11:10:19 +00:00
src/Element/Invoice.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:06:31 +00:00
Copy Link

We can probably do with renaming this element now, maybe SendSats or something more LN based rather than LNURL tipping?

We can probably do with renaming this element now, maybe `SendSats` or something more LN based rather than LNURL tipping?
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:07:58 +00:00
Copy Link

20k max? come on what about the 50k 100k?

20k max? come on what about the 50k 100k?
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:08:45 +00:00
Copy Link

Maybe we should change the min to 1 sat?

Maybe we should change the `min` to 1 sat?
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:09:35 +00:00
Copy Link

yo ROFL

`yo` ROFL
v0l commented 2023-02-07 11:12:08 +00:00 (Migrated from github.com)
Copy Link

Can we centre this?
image

This is from the profile LN link, it also looks different than the one on the note, maybe missing a prop?
image

Can we centre this? ![image](https://user-images.githubusercontent.com/1172179/217229445-73911620-bd24-43a4-803d-7afe409e1ac5.png) This is from the profile LN link, it also looks different than the one on the note, maybe missing a prop? ![image](https://user-images.githubusercontent.com/1172179/217229645-f4d7b0b5-e670-44e9-9b28-f6244f63a436.png)
👀 1
verbiricha (Migrated from github.com) reviewed 2023-02-07 11:12:30 +00:00
src/Element/LNURLTip.tsx
verbiricha (Migrated from github.com) commented 2023-02-07 11:12:30 +00:00
Copy Link

😊

😊
verbiricha (Migrated from github.com) reviewed 2023-02-07 11:13:43 +00:00
src/Element/LNURLTip.tsx
verbiricha (Migrated from github.com) commented 2023-02-07 11:13:42 +00:00
Copy Link

Yeah lemme add them,amounts is scrollable so no problem, gotta come up with emojis tho.

Yeah lemme add them,amounts is scrollable so no problem, gotta come up with emojis tho.
v0l (Migrated from github.com) reviewed 2023-02-07 11:15:15 +00:00
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:15:14 +00:00
Copy Link

100k must be eggplant no?

100k must be eggplant no?
cloudflare-pages[bot] commented 2023-02-07 11:33:07 +00:00 (Migrated from github.com)
Copy Link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b801cd
Status: ✅  Deploy successful!
Preview URL: https://fb225f0b.snort-social.pages.dev
Branch Preview URL: https://zap-modal.snort-social.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>1b801cd</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://fb225f0b.snort-social.pages.dev'>https://fb225f0b.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://zap-modal.snort-social.pages.dev'>https://zap-modal.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/fb225f0b-8767-4fa9-99f9-8cb7f2b9468a)
verbiricha (Migrated from github.com) reviewed 2023-02-07 11:33:31 +00:00
src/Element/LNURLTip.tsx
verbiricha (Migrated from github.com) commented 2023-02-07 11:33:30 +00:00
Copy Link

🚀

🚀
verbiricha (Migrated from github.com) reviewed 2023-02-07 11:37:41 +00:00
src/Element/LNURLTip.tsx
verbiricha (Migrated from github.com) commented 2023-02-07 11:37:41 +00:00
Copy Link

🍆 1M sats? 🤔

🍆 1M sats? 🤔
v0l (Migrated from github.com) reviewed 2023-02-07 11:44:28 +00:00
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:44:28 +00:00
Copy Link

Nah thats too far, maybe exploding head lol

Nah thats too far, maybe exploding head lol
v0l commented 2023-02-07 11:45:58 +00:00 (Migrated from github.com)
Copy Link

How unfortunate we now have this ugly scroll bar
image

How unfortunate we now have this ugly scroll bar ![image](https://user-images.githubusercontent.com/1172179/217236446-2595ad72-c0ef-40d2-b0e1-7f105bd60cc0.png)
v0l (Migrated from github.com) reviewed 2023-02-07 11:46:28 +00:00
src/Element/LNURLTip.tsx
v0l (Migrated from github.com) commented 2023-02-07 11:46:28 +00:00
Copy Link

🤯

🤯
verbiricha commented 2023-02-07 11:47:39 +00:00 (Migrated from github.com)
Copy Link

lemme fix scrollbar issue

lemme fix scrollbar issue
v0l commented 2023-02-07 11:53:22 +00:00 (Migrated from github.com)
Copy Link

How to scroll now? lol
image

How to scroll now? lol ![image](https://user-images.githubusercontent.com/1172179/217237854-5a800d3a-0ad3-4989-b03a-4303efb9b494.png)
verbiricha commented 2023-02-07 11:55:26 +00:00 (Migrated from github.com)
Copy Link

How to scroll now? lol

drag it or horizontal scroll on desktop

> How to scroll now? lol drag it or horizontal scroll on desktop
v0l commented 2023-02-07 11:57:47 +00:00 (Migrated from github.com)
Copy Link

How to scroll now? lol

drag it or horizontal scroll on desktop

Doesn't work for me?

> > How to scroll now? lol > > drag it or horizontal scroll on desktop Doesn't work for me?
v0l commented 2023-02-07 11:58:25 +00:00 (Migrated from github.com)
Copy Link

Number needs to handle 1M btw?

Number needs to handle 1M btw?
verbiricha commented 2023-02-07 12:09:26 +00:00 (Migrated from github.com)
Copy Link

Doesn't work for me?

Not sure why, works fine for me on Chrome/Firefox mobile/desktop.

> Doesn't work for me? Not sure why, works fine for me on Chrome/Firefox mobile/desktop.
v0l commented 2023-02-07 12:17:12 +00:00 (Migrated from github.com)
Copy Link

Doesn't work for me?

Not sure why, works fine for me on Chrome/Firefox mobile/desktop.

It works with trackpad, not with mouse

> > Doesn't work for me? > > Not sure why, works fine for me on Chrome/Firefox mobile/desktop. It works with trackpad, not with mouse
verbiricha commented 2023-02-07 12:51:27 +00:00 (Migrated from github.com)
Copy Link

Added mouse scroll to profile tabs and zap amounts.

Added mouse scroll to profile tabs and zap amounts.
v0l (Migrated from github.com) approved these changes 2023-02-07 13:25:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
v0l
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#209
No description provided.
Delete Branch "zap-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?