Workspace with decoupled nostr package #274

2023-02-11T23:13:48Z

sistemd commented

2023-02-11 23:13:48 +00:00

(Migrated from github.com)

Turned the repo into a workspace. Decoupled nostr into its own package. Some ugliness involved but I will fix it in the following PRs.

I also noticed we should probably configure prettier to format import lists, maybe I'll do that tomorrow.

I didn't change any of the nostr code, the changes are just formatting from my editor and will probably be updated in follow-up PRs. Also the Const.ts file and other rough edges will be fixed in follow ups.

Should we add eslint to git hooks?

Turned the repo into a workspace. Decoupled `nostr` into its own package. Some ugliness involved but I will fix it in the following PRs. I also noticed we should probably configure prettier to format import lists, maybe I'll do that tomorrow. I didn't change any of the `nostr` code, the changes are just formatting from my editor and will probably be updated in follow-up PRs. Also the `Const.ts` file and other rough edges will be fixed in follow ups. Should we add `eslint` to git hooks?

sistemd (Migrated from github.com) reviewed 2023-02-11 23:32:39 +00:00

v0l commented

2023-02-12 22:37:09 +00:00

(Migrated from github.com)

I tried to run yarn start in app but it failed, how should i run the site now?

I tried to run `yarn start` in app but it failed, how should i run the site now?

sistemd commented

2023-02-13 09:04:35 +00:00

(Migrated from github.com)

I updated the README in 6aba90d4a0:

This repository is a yarn workspace. To install dependencies, run yarn from the project root. To run the application, use either
$ yarn workspace @snort/app start
or
$ cd packages/app
$ yarn start

You might want to delete your existing node_modules.

I updated the README in https://github.com/v0l/snort/pull/274/commits/6aba90d4a04a27bb821c2de4e3fd975a8b27fe82: > This repository is a yarn workspace. To install dependencies, run `yarn` from the project root. To run the application, use either > > ```sh > $ yarn workspace @snort/app start > ``` > > or > > ```sh > $ cd packages/app > $ yarn start > ``` You might want to delete your existing `node_modules`.

sistemd commented

2023-02-13 09:11:44 +00:00

(Migrated from github.com)

I also updated the Dockerfile so your deployments shouldn't break (though I'm not sure what you use for deployment).

I also updated the `Dockerfile` so your deployments shouldn't break (though I'm not sure what you use for deployment).

v0l commented

2023-02-13 10:16:30 +00:00

(Migrated from github.com)

I also updated the Dockerfile so your deployments shouldn't break (though I'm not sure what you use for deployment).

We use CF pages, basically clones the repo and runs yarn build will need to update that too

> I also updated the `Dockerfile` so your deployments shouldn't break (though I'm not sure what you use for deployment). We use CF pages, basically clones the repo and runs `yarn build` will need to update that too

v0l (Migrated from github.com) approved these changes 2023-02-14 13:11:46 +00:00

v0l (Migrated from github.com) approved these changes 2023-02-14 13:53:33 +00:00

Sign in to join this conversation.

No reviewers

v0l