nostr package part 3 #365

2023-02-26T23:18:02Z

sistemd commented

2023-02-26 23:18:02 +00:00

(Migrated from github.com)

Fill in the holes of missing functionality to the point where there's a simple test which passes 🎉. The test requires the docker-compose environment to be up and talks to the nostr-rs-relay. Change onEvent, onNotice, onError etc. into a single overloaded on("event" | "notice" | "error", {}) method. Figure out a good SignedEvent abstraction, which puts together the event data, ID, and signature. Add eslint.

I also changed the callbacks to no longer be a list, because I thought it was more idiomatic. This is probably a mistake; instead, I should model all the event stuff based on Node's EventEmitter. These API changes will be done in one of the following PRs.

Fill in the holes of missing functionality to the point where there's a simple test which passes :tada:. The test requires the `docker-compose` environment to be up and talks to the `nostr-rs-relay`. Change `onEvent`, `onNotice`, `onError` etc. into a single overloaded `on("event" | "notice" | "error", {})` method. Figure out a good `SignedEvent` abstraction, which puts together the event data, ID, and signature. Add eslint. I also changed the callbacks to no longer be a list, because I thought it was more idiomatic. This is probably a mistake; instead, I should model all the event stuff based on Node's [EventEmitter](https://nodejs.org/api/events.html#class-eventemitter). These API changes will be done in one of the following PRs.

sistemd (Migrated from github.com) reviewed 2023-02-26 23:18:35 +00:00

cloudflare-pages[bot] commented

2023-02-26 23:25:24 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`e5e18ca`
Status:	✅ Deploy successful!
Preview URL:	https://c3d575db.snort-social.pages.dev
Branch Preview URL:	https://nostr-package-3.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>e5e18ca</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://c3d575db.snort-social.pages.dev'>https://c3d575db.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://nostr-package-3.snort-social.pages.dev'>https://nostr-package-3.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/c3d575db-f328-45df-a375-e64f7997ed40)

sistemd (Migrated from github.com) reviewed 2023-02-26 23:25:45 +00:00

sistemd (Migrated from github.com) left a comment

(Note to self: review this PR one more time.)