use redux for NoteCreator state management #494

Kieran · 2023-04-06T17:28:17Z

SamSamskies commented

2023-04-06 17:28:17 +00:00

(Migrated from github.com)

resolves https://github.com/v0l/snort/issues/408

This fixes a bug where the modal closes while replying to a note. This happens if the thread re-renders while you are replying.

Drafts of notes are also now automatically saved unless the user clicks the cancel button.

resolves https://github.com/v0l/snort/issues/408 This fixes a bug where the modal closes while replying to a note. This happens if the thread re-renders while you are replying. Drafts of notes are also now automatically saved unless the user clicks the cancel button.

verbiricha (Migrated from github.com) reviewed 2023-04-06 17:28:17 +00:00

v0l commented

2023-04-06 21:32:56 +00:00

(Migrated from github.com)

When i click on the NoteCreator on Conversations tab is closing for me

👀 1

cloudflare-pages[bot] commented

2023-04-07 15:00:47 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`4d5f1e4`
Status:	✅ Deploy successful!
Preview URL:	https://de4f9f5b.snort-social.pages.dev
Branch Preview URL:	https://use-redux-for-note-creator-s.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>4d5f1e4</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://de4f9f5b.snort-social.pages.dev'>https://de4f9f5b.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://use-redux-for-note-creator-s.snort-social.pages.dev'>https://use-redux-for-note-creator-s.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/de4f9f5b-7dea-4387-b79a-3c7fa4e76d44)

SamSamskies commented

2023-04-07 15:02:53 +00:00

(Migrated from github.com)

@v0l the bug you found should be fixed.

v0l commented

2023-04-07 17:15:51 +00:00

(Migrated from github.com)

Seems like its still an issue, I click the note creator floating button, type some shit then click the background.

Then i click a reply button and try to click on the textarea and it closes the note creator

Seems like its still an issue, I click the note creator floating button, type some shit then click the background. Then i click a reply button and try to click on the textarea and it closes the note creator

👀 1

SamSamskies commented

2023-04-07 19:33:08 +00:00

(Migrated from github.com)

@v0l okay now it should be fixed 🤞