Kieran
/
snort
4
13
Fork 14
Code Issues 71 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

Fix Wavlake zine links without trailing slash, ignore top and new links #537

Merged
blastshielddown merged 1 commits from fix-wavlake-embed-regex into main 2023-04-24 15:27:04 +00:00
Conversation 5 Commits 1 Files Changed 1 +1 -1
blastshielddown commented 2023-04-20 20:29:13 +00:00 (Migrated from github.com)
Copy Link
No description provided.
SamSamskies (Migrated from github.com) requested changes 2023-04-20 20:43:40 +00:00
SamSamskies (Migrated from github.com) left a comment
Copy Link

you committed a package-lock.json by accident.

you committed a package-lock.json by accident.
blastshielddown (Migrated from github.com) reviewed 2023-04-20 21:02:24 +00:00
SamSamskies (Migrated from github.com) reviewed 2023-04-20 21:09:37 +00:00
blastshielddown (Migrated from github.com) reviewed 2023-04-20 22:41:31 +00:00
SamSamskies (Migrated from github.com) approved these changes 2023-04-21 03:07:46 +00:00
SamSamskies (Migrated from github.com) left a comment
Copy Link

🚀

🚀
SamSamskies commented 2023-04-21 03:10:49 +00:00 (Migrated from github.com)
Copy Link

I'm not sure why the linting is failing. I don't think it has anything to do with what you did, but could you try rebasing main and then running yarn workspace @snort/app format?

I'm not sure why the linting is failing. I don't think it has anything to do with what you did, but could you try rebasing main and then running `yarn workspace @snort/app format`?
blastshielddown commented 2023-04-21 13:38:06 +00:00 (Migrated from github.com)
Copy Link

Strange. Ran prettier and linting comes out OK locally. I also tried splitting the regex into 2 lines to see if that would help -- no dice. Also tried a completely new branch from main and PR'd from that one -- same error. Not sure what the issue is here

Strange. Ran prettier and linting comes out OK locally. I also tried splitting the regex into 2 lines to see if that would help -- no dice. Also tried a completely new branch from main and PR'd from that one -- same error. Not sure what the issue is here
SamSamskies commented 2023-04-21 15:52:41 +00:00 (Migrated from github.com)
Copy Link

@blastshielddown you have to rebase main first and then run prettier. the lint error is not about the changes you made. not sure why it's doing that.

@blastshielddown you have to rebase `main` first and then run prettier. the lint error is not about the changes you made. not sure why it's doing that.
SamSamskies commented 2023-04-21 15:54:07 +00:00 (Migrated from github.com)
Copy Link

you need to make sure to fetch the updates from the main branch in the snort repo.

you need to make sure to fetch the updates from the `main` branch in the snort repo.
blastshielddown commented 2023-04-21 17:29:22 +00:00 (Migrated from github.com)
Copy Link

My force push triggered closing this, reopening now (hoping i did the rebase right)

My force push triggered closing this, reopening now (hoping i did the rebase right)
Sign in to join this conversation.
Reviewers
No reviewers
SamSamskies
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#537
No description provided.
Delete Branch "fix-wavlake-embed-regex"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?