Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

feat: group images into a gallery #639

Merged
Kieran merged 1 commits from fernandoporazzi/snort:group-post-images into main 2023-10-05 13:10:46 +00:00
Conversation 1 Commits 1 Files Changed 3 +166 -49
fernandoporazzi commented 2023-10-03 22:08:57 +00:00
Contributor
Copy Link

Solves #626

Results can be found in the attachments and also externally on video: https://streamable.com/q492ui

I've done some testing with different types of combinations, such as:
text -> gallery -> text -> gallery
gallery -> video -> gallery
link -> text -> gallery
hashtag -> gallery -> video -> gallery

and it seems to be working fine. If the <Text /> component is used elsewhere other than the timeline and the post itself, it might need some extra testing.

This npub was created in order to test all those combinations: npub1027c702nhecpzy6jt3wyvjpw6j8m7n9x0xyvn00xt69zlljv8fts5c34hd

Solves #626 Results can be found in the attachments and also externally on video: https://streamable.com/q492ui I've done some testing with different types of combinations, such as: text -> gallery -> text -> gallery gallery -> video -> gallery link -> text -> gallery hashtag -> gallery -> video -> gallery and it seems to be working fine. If the `<Text />` component is used elsewhere other than the timeline and the post itself, it might need some extra testing. This npub was created in order to test all those combinations: `npub1027c702nhecpzy6jt3wyvjpw6j8m7n9x0xyvn00xt69zlljv8fts5c34hd`
Screenshot 2023-10-03 at 21.54.47.png
2.2 MiB
Screenshot 2023-10-03 at 21.55.13.png
2.5 MiB
Screenshot 2023-10-03 at 21.55.02.png
2.3 MiB
Screenshot 2023-10-03 at 21.54.47.png Screenshot 2023-10-03 at 21.55.13.png Screenshot 2023-10-03 at 21.55.02.png
fernandoporazzi requested review from Kieran 2023-10-03 22:11:32 +00:00
Kieran reviewed 2023-10-05 09:55:50 +00:00
packages/app/src/Element/Text.tsx Outdated
@ -86,3 +130,1 @@
} else if (lenCtr + a.content.length > truncate) {
lenCtr += a.content.length;
return <div className="text-frag">{a.content.slice(0, truncate - lenCtr)}...</div>;
chunks = chunks.concat(null);
Kieran commented 2023-10-05 09:50:02 +00:00
Owner
Copy Link

This should be continue instead

This should be `continue` instead
fernandoporazzi commented 2023-10-05 12:18:44 +00:00
Author
Contributor
Copy Link

Solved

Solved
fernandoporazzi marked this conversation as resolved
packages/system/src/text.ts Outdated
@ -190,3 +190,3 @@
.map(a => {
if (typeof a === "string") {
if (a.length > 0) {
if (a.trim().length > 0) {
Kieran commented 2023-10-05 09:55:38 +00:00
Owner
Copy Link

Should not trim because empty text frag is important for spacing

Should not trim because empty `text` frag is important for spacing
fernandoporazzi commented 2023-10-05 12:17:42 +00:00
Author
Contributor
Copy Link

Keeping that empty text fragment might be a bit of an issue when grouping images. It would break the grouping for loop if the next element is not a media of type image.

We could keep on grouping images if there is an empty text fragment between them, but that would increase the complexity of the code as well.

Maybe we can find a proper way to handle spacing using a CSS-only solution.

Currently the space is not so messed up, I just think the line-height is a bit too high. If we lower that value, it might remove the space between the text you see on the video attached.

Keeping that empty text fragment might be a bit of an issue when grouping images. It would break the grouping for loop if the next element is not a media of type image. We could keep on grouping images if there is an empty text fragment between them, but that would increase the complexity of the code as well. Maybe we can find a proper way to handle spacing using a CSS-only solution. Currently the space is not so messed up, I just think the line-height is a bit too high. If we lower that value, it might remove the space between the text you see on the video attached.
Kieran commented 2023-10-05 13:05:35 +00:00
Owner
Copy Link

Ok we can keep it trimmed for now, but i used to have this and it messed up some of the layout on posts

Ok we can keep it trimmed for now, but i used to have this and it messed up some of the layout on posts
Kieran marked this conversation as resolved
fernandoporazzi force-pushed group-post-images from 18c54877d5 to 8e34a7a078 2023-10-05 12:18:27 +00:00 Compare
Kieran merged commit 7c839ae3a8 into main 2023-10-05 13:10:46 +00:00
Kieran deleted branch group-post-images 2023-10-05 13:10:47 +00:00
Kieran commented 2023-10-05 13:40:00 +00:00
Owner
Copy Link

Ah yes here it is, its the hashtags: image

Ah yes here it is, its the hashtags: ![image](/attachments/1a75b403-b08e-4ffa-808d-1caf990568ce)
image.png
27 KiB
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Kieran
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#639
No description provided.
Delete Branch "fernandoporazzi/snort:group-post-images"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?