Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

fix: issue #671 unreadable profile pop-ups #673

Merged
Kieran merged 5 commits from jamesmagoo/snort:main into main 2023-11-16 11:43:43 +00:00
Conversation 3 Commits 5 Files Changed 2 +8
jamesmagoo commented 2023-11-09 12:55:35 +00:00
Contributor
Copy Link

Added css to handle unreadable text in light-mode

First time contributing, not sure if I'm following correct procedure. Please let me know if not.

5k invoice:
lnbc50u1pj5e4jlpp5v8myp524mq4j2m5aka6ql4u4uqe2vpv7wvrls2u6pl5chd8kzfrsdzyve5hsw3qd9ehxat9yq3nvde3yp6kuun9v9jxzcnvv5s8qun0ve5kcefqwphhqtt4wpescqzzsxqyz5vqsp5p4qgpwf5zyq59x5lsxxqpwnn9pzkwyhq2cpvcgsyhrdeu9cw6jks9qyyssq6gjlswgjmzs6p0avyxz4rm5fduxk4pctjmgetshc8ql5mspdjr6qucsvqv8pgcvudtd8jtsqr4005955r63nhcau53dd64277thvusqpavfv7e

Added css to handle unreadable text in light-mode First time contributing, not sure if I'm following correct procedure. Please let me know if not. 5k invoice: lnbc50u1pj5e4jlpp5v8myp524mq4j2m5aka6ql4u4uqe2vpv7wvrls2u6pl5chd8kzfrsdzyve5hsw3qd9ehxat9yq3nvde3yp6kuun9v9jxzcnvv5s8qun0ve5kcefqwphhqtt4wpescqzzsxqyz5vqsp5p4qgpwf5zyq59x5lsxxqpwnn9pzkwyhq2cpvcgsyhrdeu9cw6jks9qyyssq6gjlswgjmzs6p0avyxz4rm5fduxk4pctjmgetshc8ql5mspdjr6qucsvqv8pgcvudtd8jtsqr4005955r63nhcau53dd64277thvusqpavfv7e
jamesmagoo added 1 commit 2023-11-09 12:55:41 +00:00
fix: issue #671 unreadable profile pop-ups
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8014d84b3d
Kieran commented 2023-11-09 15:37:06 +00:00
Owner
Copy Link

we use .light class on page, so in css you need to do .light .my-class if you want to change only for light theme

we use `.light` class on page, so in css you need to do `.light .my-class` if you want to change only for light theme
jamesmagoo added 1 commit 2023-11-09 18:27:58 +00:00
flix css class to light as per comment
Some checks failed
continuous-integration/drone/pr Build is failing
Details
9082630cc2
jamesmagoo added 1 commit 2023-11-10 14:45:44 +00:00
Merge remote-tracking branch 'upstream/main'
Some checks failed
continuous-integration/drone/pr Build is failing
Details
b5df7dbb6e
Kieran requested changes 2023-11-10 18:41:13 +00:00
packages/app/src/Element/AsyncButton.css Outdated
@ -23,2 +23,4 @@
box-shadow: rgba(0, 0, 0, 0.2) 0 1px 3px;
}
@media (prefers-color-scheme: light) {
Kieran commented 2023-11-10 18:40:54 +00:00
Owner
Copy Link

@media query isnt needed

`@media` query isnt needed
jamesmagoo marked this conversation as resolved
jamesmagoo added 2 commits 2023-11-12 22:51:51 +00:00
Remove media queries
Some checks failed
continuous-integration/drone/pr Build is failing
Details
815fc344f1
jamesmagoo changed title from WIP: fix: issue #671 unreadable profile pop-ups to fix: issue #671 unreadable profile pop-ups 2023-11-15 09:53:01 +00:00
Kieran merged commit d0bcc59372 into main 2023-11-16 11:43:40 +00:00
Kieran commented 2023-11-16 11:43:57 +00:00
Owner
Copy Link

Paste new invoice pls

Paste new invoice pls
jamesmagoo commented 2023-11-18 08:42:31 +00:00
Author
Contributor
Copy Link

lnbc50u1pj4s78dpp569tu3w3dz3wvmqd78a8x4mp8mq50s8t7khrkrmynd0zff7l5c9hqdpzd9ehxat9yq3nvde3yqs9q53qd4jhyem9vscqzzsxqyz5vqsp5vpj2ym64mvzv55vff8puwqx5uzdse38y3uk90xgfs65xwxffddrs9qyyssqzqyuv2s248snqjp956ec0vktymmamlgklqn042974jn92lxuuaq3yt3wu066c8lau3g8mjkdxuc52kxdc59luzawv73f3p2f6wvjnfgp44lnpk

lnbc50u1pj4s78dpp569tu3w3dz3wvmqd78a8x4mp8mq50s8t7khrkrmynd0zff7l5c9hqdpzd9ehxat9yq3nvde3yqs9q53qd4jhyem9vscqzzsxqyz5vqsp5vpj2ym64mvzv55vff8puwqx5uzdse38y3uk90xgfs65xwxffddrs9qyyssqzqyuv2s248snqjp956ec0vktymmamlgklqn042974jn92lxuuaq3yt3wu066c8lau3g8mjkdxuc52kxdc59luzawv73f3p2f6wvjnfgp44lnpk
Sign in to join this conversation.
Reviewers
No reviewers
Kieran
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#673
No description provided.
Delete Branch "jamesmagoo/snort:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?