Remove unnecessary element from note #682
Labels
No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Kieran/snort#682
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Tanel pointed this out, we have this line that seems to be there for no reason. Why do we need it if we already have a reactions count above that's clickable to see summaries? "Peter Todd & 15 others zapped"
I think we could remove this entire line without affecting anything.
This is to show the top zapper, Peter Todd zapped the most and is first, i don't think we should remove this.
I would expect the opposite comment to be made "it would be nice if we could see at a glance who zapped the post, maybe the top zapper and how many people zapped"
I see. Well, it looks like it's a clickable reactions thing, like the one above, but you can't click it and it's not clear what it is. The way you explained it makes a lot more sense.
Maybe we can make it clickable and go to zaps reactions tab?
Can we also align it to the left so the PFP is flush with the comments icon?