Remove unnecessary element from note #682

Closed
opened 2023-11-17 02:06:58 +00:00 by Karnage · 3 comments
Collaborator

Tanel pointed this out, we have this line that seems to be there for no reason. Why do we need it if we already have a reactions count above that's clickable to see summaries? "Peter Todd & 15 others zapped"

CleanShot 2023-11-17 at 11.03.00@2x

I think we could remove this entire line without affecting anything.

Tanel pointed this out, we have this line that seems to be there for no reason. Why do we need it if we already have a reactions count above that's clickable to see summaries? "Peter Todd & 15 others zapped" ![CleanShot 2023-11-17 at 11.03.00@2x](/attachments/5164cf20-9538-4b94-b4e3-fee4e19a92fc) I think we could remove this entire line without affecting anything.
Karnage added the
enhancement
label 2023-11-17 02:06:58 +00:00
Owner

This is to show the top zapper, Peter Todd zapped the most and is first, i don't think we should remove this.

I would expect the opposite comment to be made "it would be nice if we could see at a glance who zapped the post, maybe the top zapper and how many people zapped"

This is to show the top zapper, Peter Todd zapped the most and is first, i don't think we should remove this. I would expect the opposite comment to be made "it would be nice if we could see at a glance who zapped the post, maybe the top zapper and how many people zapped"
Author
Collaborator

I see. Well, it looks like it's a clickable reactions thing, like the one above, but you can't click it and it's not clear what it is. The way you explained it makes a lot more sense.

Maybe we can make it clickable and go to zaps reactions tab?

I see. Well, it looks like it's a clickable reactions thing, like the one above, but you can't click it and it's not clear what it is. The way you explained it makes a lot more sense. Maybe we can make it clickable and go to zaps reactions tab?
Author
Collaborator

Can we also align it to the left so the PFP is flush with the comments icon?

Can we also align it to the left so the PFP is flush with the comments icon?
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#682
No description provided.