Missing comment counts (very important for a social platform) #705

Closed
opened 2023-11-28 06:51:38 +00:00 by Karnage · 4 comments
Collaborator

I thought we had this working already but for some reason the comment counts don't show up (anymore?). Maybe they never worked? i dunno. Pam brought this up to me via feedback and I agree that it's super important to have these to send users social signal that conversations are happening. Otherwise it looks like nobody is talking!

Here is the screenshot with the issue, no comment counts at all:

CleanShot 2023-11-28 at 15.49.06@2x

I think this is a really important thing to fix.

I thought we had this working already but for some reason the comment counts don't show up (anymore?). Maybe they never worked? i dunno. Pam brought this up to me via feedback and I agree that it's super important to have these to send users social signal that conversations are happening. Otherwise it looks like nobody is talking! Here is the screenshot with the issue, no comment counts at all: ![CleanShot 2023-11-28 at 15.49.06@2x](/attachments/6eea7223-18aa-4159-9be1-6d8586f7f964) I think this is a really important thing to fix.
Karnage added the
enhancement
20k
labels 2023-11-28 06:51:38 +00:00
Owner

The reply counts only work on thread view, on the timelines you would have to load every reply to every post to count the replies, or you could use NIP-45 COUNT but not many relays support it

The reply counts only work on thread view, on the timelines you would have to load every reply to every post to count the replies, or you could use NIP-45 COUNT but not many relays support it
Author
Collaborator

How does Damus do it to counts directly in feed?

How does Damus do it to counts directly in feed?
Owner

It doesnt, it does it on thread only, same as us

It doesnt, it does it on thread only, same as us
Owner

We partially have counts now for threads which you viewed more than once since those threads will have replies saved in the relay worker cache

We partially have counts now for threads which you viewed more than once since those threads will have replies saved in the relay worker cache
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#705
No description provided.