Kieran/zap.stream
5
8
Fork 9
Code Issues 29 Pull Requests 1 Packages Projects 1 Releases Wiki Activity

feat: Enhance support for a wider variety of video URL formats. #101

Open
nickydev wants to merge 4 commits from nickydev/stream:main into main
pull from: nickydev/stream:main
merge into: Kieran:main
Conversation 2 Commits 4 Files Changed 5 +79 -92
nickydev commented 2023-10-04 07:55:18 +00:00
First-time contributor
Copy Link
  • Enhance support for a wider variety of video URL formats.
  • The manual stream allows for the update of the Recording URL after the live stream has ended.
- Enhance support for a wider variety of video URL formats. - The manual stream allows for the update of the Recording URL after the live stream has ended.
nickydev added 4 commits 2023-10-04 07:55:22 +00:00
feat: The manual stream allows updating the Recording URL
Some checks failed
continuous-integration/drone/pr Build is failing
Details
44ad695823
nickydev commented 2023-10-04 09:25:15 +00:00
Author
First-time contributor
Copy Link

This is my live event url: https://zap.stream/naddr1qq9rzd3excengdp3xucsygpakhsmnk490nr2042j4p4gw46wagn9up6emh4c04zwqunl08kc35psgqqqwens29ax3f

http://localhost:8080/naddr1qq9rzd3excengdp3xucsygpakhsmnk490nr2042j4p4gw46wagn9up6emh4c04zwqunl08kc35psgqqqwens29ax3f

This is my live event url: https://zap.stream/naddr1qq9rzd3excengdp3xucsygpakhsmnk490nr2042j4p4gw46wagn9up6emh4c04zwqunl08kc35psgqqqwens29ax3f http://localhost:8080/naddr1qq9rzd3excengdp3xucsygpakhsmnk490nr2042j4p4gw46wagn9up6emh4c04zwqunl08kc35psgqqqwens29ax3f
nickydev requested review from Kieran 2023-10-05 01:34:31 +00:00
Kieran commented 2023-10-05 09:48:28 +00:00
Owner
Copy Link

Not sure about this, i think the recording makes sense but there shouldn't be any reason why we would allow posting anything other than .m3u8, ofc, you can always have another app which will post any link in the "recording" tag we cant control that

Not sure about this, i think the recording makes sense but there shouldn't be any reason why we would allow posting anything other than .m3u8, ofc, you can always have another app which will post any link in the "recording" tag we cant control that
👍 1
Some checks are pending
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push
Required
This pull request has changes conflicting with the target branch.
  • package.json
  • src/element/live-video-player.tsx
  • src/element/stream-editor.tsx
  • src/pages/stream-page.css
  • yarn.lock
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:nickydev-main
git checkout nickydev-main
Sign in to join this conversation.
Reviewers
No reviewers
Kieran
Labels
Clear labels   
backend

An issue related to the hosted streaming backend

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
needs:design

   
P1

   
P2

   
P3

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
backend
bug
duplicate
enhancement
help wanted
invalid
needs:design
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/zap.stream#101
No description provided.
Delete Branch "nickydev/stream:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?