feat: show top zappers #3

						
				@ -37,1 +78,4 @@

				  const login = useLogin();

				  const events = messages.data ?? [];

				  const zaps = events

				    .filter((ev) => ev.kind === EventKind.ZapReceipt)

Kieran commented

2023-06-25 12:04:14 +00:00

One problem here is that parseZap wont work unless we have the profile loaded, so we need a way to make sure that we're requesting those profiles otherwise the zaps will be invalid

👀 1

verbiricha commented

2023-06-25 16:56:35 +00:00

Added loading when parse zap fails due to mising profile d3917fc418

Added loading when parse zap fails due to mising profile d3917fc418cf1cd5d799cb7f0fc97bc88f57f7fa

Kieran marked this conversation as resolved

src/element/live-chat.tsx Outdated

						
				@ -38,0 +80,4 @@

				  const zaps = events

				    .filter((ev) => ev.kind === EventKind.ZapReceipt)

				    .map((ev) => parseZap(ev, System.ProfileLoader.Cache))

				    .filter((z) => z);

Kieran commented

2023-06-25 12:04:34 +00:00

Missing filter isValid for those parsed zaps

Missing filter `isValid` for those parsed zaps

👀 1

verbiricha commented

2023-06-25 16:41:14 +00:00

fixed.

Kieran marked this conversation as resolved

verbiricha added 1 commit 2023-06-25 16:41:04 +00:00

fix: filter by valid zaps afd8313ea2

verbiricha added 1 commit 2023-06-25 16:54:16 +00:00

fix: load profile metadata if profile is unached d3917fc418

verbiricha added 1 commit 2023-06-25 16:57:11 +00:00

fix: add missing dep to useMemo 64cf924131

Kieran reviewed 2023-06-25 19:22:54 +00:00

src/element/live-chat.tsx

						
				@ -85,0 +145,4 @@

				      parsed.errors.includes("zap service pubkey doesn't match") &&

				      parsed.sender

				    ) {

				      System.ProfileLoader.TrackMetadata(parsed.sender);

Kieran commented

2023-06-25 19:22:00 +00:00

You should return a function here to cleanup the profile tracking

return () => System.ProfileLoader.UntrackMetadata(parsed.sender);

I will also extend the system package to allow async fetching of profiles to make it a bit easier

You should return a function here to cleanup the profile tracking ``` return () => System.ProfileLoader.UntrackMetadata(parsed.sender); ``` I will also extend the system package to allow async fetching of profiles to make it a bit easier

verbiricha commented

2023-06-25 19:58:24 +00:00

sounds good, added cleanup function return.

Kieran marked this conversation as resolved

verbiricha added 1 commit 2023-06-25 19:58:09 +00:00

fix: cleanup fn b241738f67

verbiricha added 1 commit 2023-06-25 19:58:55 +00:00

fix: type efb8df5bcf

Kieran approved these changes 2023-06-25 21:37:32 +00:00

Kieran referenced this issue from a commit

2023-06-25 21:37:43 +00:00

Merge pull request 'feat: show top zappers' (#3) from verbiricha/stream:top-zappers into main