huggingface/candle
1
0
Fork 0
mirror of https://github.com/huggingface/candle.git synced 2025-06-20 04:00:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a comment. (#155)

Browse Source
This commit is contained in:
Laurent Mazare
2023-07-13 11:11:37 +01:00
committed by GitHub
parent 50b0946a2d
commit dfabc708f2
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
candle-core/src/tensor.rs
View File

@ -19,12 +19,13 @@ impl TensorId {
pub struct Tensor_ { pub struct Tensor_ {
id: TensorId, id: TensorId,
// Storage uses a mutex here so inner mutability is available and borrow rules are checked // As we provide inner mutability on the tensor content, the alternatives are:
// dynamically. The alternatives would be:
// - Using a mutex, this would have the highest cost when retrieving the storage but would // - Using a mutex, this would have the highest cost when retrieving the storage but would
// prevent errors when concurrent access takes place. Mutex would also be subject to // prevent errors when concurrent access takes place. Mutex would also be subject to
// deadlocks for example using the current code if the same tensor is used twice by a single // deadlocks for example using the current code if the same tensor is used twice by a single
// binary op. // binary op.
// - Using a refcell unsafe cell would have some intermediary cost, borrow checking would be
// verified dynamically, but the resulting tensors would not be send or sync.
// - Using an unsafe cell would have the lowest cost but undefined behavior on concurrent // - Using an unsafe cell would have the lowest cost but undefined behavior on concurrent
// accesses. // accesses.
// Ideally, we would use Arc<Storage> for tensors on which we don't plan on modifying the data // Ideally, we would use Arc<Storage> for tensors on which we don't plan on modifying the data