mirror of
git://jb55.com/damus
synced 2024-09-16 02:03:45 +00:00
0f86a41c4a
Summary ------- This patch fixes the issue where the user might see notes from users that they have muted, if such note has been reposted or quoted. Furthermore, this patch introduces some improvements on some of the associated views, making them more reusable. Testing of the fix ------------------ **PASS** **Device:** iPhone 14 Pro simulator **iOS:** 17.0 **Damus:** This commit **Test steps:** 1. Create two test accounts (if not created already). We will use test account "A". Test account "B" is an external test account 2. Make some notes from test account "B" (if non existent) 3. Switch to account "A" 4. Under test account "A", follow account "B" 5. Repost a note from account "B", and quote another note from account "B" 6. Access "account B"'s timeline. Repost and quoted note should all be visible. Layout should look as usual 7. Click on the reposted note. Should appear and it should look normal 8. Click on the note with the quote. Should appear and it should look normal 9. Click on the quoted note. Should appear and it should look normal 10. Now mute account "B" 12. Go back to account "A"'s timeline 13. Repost should appear, but the reposted content should be hidden behind a mute box. Clicking on show/hide should show or hide muted content 14. Note with quoted content should appear, but the quoted content should be hidden behind a mute box. Clicking on show/hide should work as expected 15. Make sure that the layout in steps 13 and 14 look good. 16. Click on the repost to access the thread view. Should be muted as expected. 17. Add a comment to the repost. Comment should appear even if the mute box hides the main note 18. Click on the note with quote to open its thread view. Comments should appear, main note should appear, but quoted content should be behind the mute box 19. Under account "B", add a comment to the quoted notes 20. Under account "A", check in the thread view that "B"'s reply is behind a mute box 21. Reply to the note with the quote. Check that the note appears correctly and that quoted content is behind the mute box (in the post composer view) 22. Find on Nostr a post where one of the replies contains a quoted note. Mute the user of the quoted content, and check that quoted content is now in a mute box Smoke sanity test ----------------- **PASS** **Device:** iPhone 14 pro simulator **iOS:** 16.4 **Test steps:** Browse a timeline filled with real notes and comments. Go through different notes and threads, mute some users, just to make sure nothing else appears obsviously broken. Other notes ----------- I removed this code: ``` .frame(maxWidth: .infinity, minHeight: PFP_SIZE) ``` from `EventShell`, because it was causing the layout to break on "threaded" style event view with muted quoted content (e.g. in a reply with quoted content). The line of code dates back to `495859e07f`, but I am not sure why this line existed in the first place, or if removing it has any negative impact. Closes: https://github.com/damus-io/damus/issues/1216 Changelog-Fixed: Hide quoted or reposted notes from people whom the user has muted. (#1216) Signed-off-by: Daniel D’Aquino <daniel@daquino.me> Reviewed-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com> |
||
|---|---|---|
| .github/workflows | ||
| damus | ||
| damus-c | ||
| damus.xcodeproj | ||
| damusTests | ||
| damusUITests | ||
| devtools | ||
| docs | ||
| flatbuffers | ||
| nostrdb | ||
| nostrscript | ||
| .envrc | ||
| .gitignore | ||
| .mailmap | ||
| .rgignore | ||
| CHANGELOG.md | ||
| LICENSE | ||
| Makefile | ||
| Package.swift | ||
| README.md | ||
| shell.nix | ||
| ss.png | ||
| TODO | ||
| transifex.yml | ||
damus
A twitter-like nostr client for iPhone, iPad and MacOS.
Spec Compliance
damus implements the following Nostr Implementation Possibilities
- NIP-01: Basic protocol flow
- NIP-08: Mentions
- NIP-10: Reply conventions
- NIP-12: Generic tag queries (hashtags)
Getting Started on Damus
Damus iOS
- Get the Damus app on the iOS App Store: https://apps.apple.com/ca/app/damus/id1628663131
⚙️ Settings (gear icon, top right)
- Relays: You can add more relays to send your notes to by tapping the "+".
- Find more relays to add: https://nostr.info/relays/
- Public Key (pubkey): Your public, personal address and how people can find and tag you
- Secret Key: Your private key unique to you. Never share your private key publically and share with other clients at your own risk!
- Save your keys somewhere safe
- Log out
🏠 Personal Feed (home icon, bottom navigation)
- Feed from everyone you follow
- Can post notes by tapping the blue + button
Notes (under 🏠 Personal Feed)
- Sending a Note is easy and it goes to both your 🏠 Personal and 🔍 Global Feeds
- To tag a user you must grab their pubkey:
- Search their username in the search bar at the top of the 🔍 Global Feed and click their profile
- Tap the 🔑 icon which will copy their pubkey to your clipboard
- Go back to your 🏠 Personal Feed and tap the blue + button to compose your Note
- Add @ direcly followed by the pubkey (e.g.,
@npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s)
- You can also long-press a Note to grab their User ID aka pubkey or Note ID to link directly to a Note.
- Currently you can't delete your Notes in the iOS app
- Share images by pasting the image url which you can grab from imgbb, imgur, etc. (i.e.,
https://i.ibb.co/2SHZbwm/alpha60.jpg). Currently images only load for people you follow in the 🏠 Personal Feed. Images are not automatically loaded in 🔍 Global Feed - Engaging with Notes
- 💬 Replying to a Note: Tap the chat icon underneath the note. This will show up in the users’ notifications and in your 🏠 Personal and 🔍 Global Feeds
- ♺ Reposts: Tap the repost icon which will show up in your 🏠 Personal and 🔍 Global Feeds
- ♡ Likes: Tap the heart icon. Users will not get a notification, and cannot see who liked their note (currently, web clients can see your pfp only)
- Formatting Notes (may not format as intended in other web clients)
- Italics: 1 asterisk
*italic* - Bold: 2 asterisk
**bold** - Strikethrough: 1 tildes
~strikethrough~ - Code: 1 back-tick
`code`
- Italics: 1 asterisk
💬 Encrypted DMs (chat app, bottom navigation)
- Tap the chat icon and you'll notice there's nothing to see at first. Go to a user profile and tap the 💬 chat icon next to the follow button to begin a DM
🔍 Global Feed (magnify glass, bottom navigation)
- View the Global Feed from all the relays you've added in ⚙️ Settings. Currently you can only search hashtags and user names and pubkeys
🔔 Notifications
- All your notifications except 💬 DMs
👤 Change Your Profile (PFP) and Bio
- Go to your Profile Page on Damus app
- Tap on Edit button at the top
- You will see text fields to update your information and bio
- For PFP, insert a URL containing your image (support video: https://cdn.jb55.com/vid/pfp-editor.mp4)
- Save
⚡️ Request Sats
(Sats or Satoshis are the smallest denomination of bitcoin)
Alby (browser extension)
- Get the Alby browser extension and create your Alby address [yourname]@getalby.com or connect your existing Lightning wallet
- Convert your Damus secret key from nsec to hex at https://damus.io/key then go to Settings in Alby and under the Nostr section at the bottom of the page add your private hex key. You can also generate new address in the extension
- Click the Alby extension > click Receive > enter the amount of Sats > click Get Invoice > click Copy > then paste into Damus
- Note: On Damus Web it will appear as a string of characters but on Damus iOS it will appear as a clickable image
Zeus (mobile app)
- Download Zeus app (iOS, Google, APK)
- Tap Get Started button > tap Connect a node > click on + sign (top right) > select Indhub > press Scan Lndhub QR > (from the Alby browser extension… click your account on the top left > click Manage Accounts > click 3-dot menu to right of your account and click Export Account to get a QR code then go back to Zeus app) > scan the QR Code and tap Save Node Config button
- To create an invoice tap Lightning > tap Receive > type in amount > tap Create Invoice > tap Copy Invoice > paste into a new Damus note
Contributing
Contributors welcome! Start by examining known issues: https://github.com/damus-io/damus/issues.
Mailing lists
We have a few mailing lists that anyone can join to get involved in damus development:
- dev - development discussions
- patches - code submission and review
- product - product discussions
- design - design discussions
Contributing
Privacy
Your internet protocol (IP) address is exposed to the relays you connect to, and third party media hosters (e.g. nostr.build, imgur.com, giphy.com, youtube.com etc.) that render on Damus. If you want to improve your privacy, consider utilizing a service that masks your IP address (e.g. a VPN) from trackers online.
The relay also learns which public keys you are requesting, meaning your public key will be tied to your IP address.
Translations
Translators welcome! Join the Transifex project.
All user-facing strings must have a comment in order to provide context to translators. If a SwiftUI component has a comment parameter, use that. Otherwise, wrap your string with NSLocalizedString with the comment field populated.
Awards
There may be nostr badges awarded for contributors in the future... :)
First contributors:
- @randymcmillan
- @jcarucci27
git log bot
npub1fjtdwclt9lspjy8huu3qklr7eklp5uq90u6yh8mec290pqxraccqlufnas