mirror of
git://jb55.com/damus
synced 2024-09-18 19:23:49 +00:00
0f86a41c4a
Summary ------- This patch fixes the issue where the user might see notes from users that they have muted, if such note has been reposted or quoted. Furthermore, this patch introduces some improvements on some of the associated views, making them more reusable. Testing of the fix ------------------ **PASS** **Device:** iPhone 14 Pro simulator **iOS:** 17.0 **Damus:** This commit **Test steps:** 1. Create two test accounts (if not created already). We will use test account "A". Test account "B" is an external test account 2. Make some notes from test account "B" (if non existent) 3. Switch to account "A" 4. Under test account "A", follow account "B" 5. Repost a note from account "B", and quote another note from account "B" 6. Access "account B"'s timeline. Repost and quoted note should all be visible. Layout should look as usual 7. Click on the reposted note. Should appear and it should look normal 8. Click on the note with the quote. Should appear and it should look normal 9. Click on the quoted note. Should appear and it should look normal 10. Now mute account "B" 12. Go back to account "A"'s timeline 13. Repost should appear, but the reposted content should be hidden behind a mute box. Clicking on show/hide should show or hide muted content 14. Note with quoted content should appear, but the quoted content should be hidden behind a mute box. Clicking on show/hide should work as expected 15. Make sure that the layout in steps 13 and 14 look good. 16. Click on the repost to access the thread view. Should be muted as expected. 17. Add a comment to the repost. Comment should appear even if the mute box hides the main note 18. Click on the note with quote to open its thread view. Comments should appear, main note should appear, but quoted content should be behind the mute box 19. Under account "B", add a comment to the quoted notes 20. Under account "A", check in the thread view that "B"'s reply is behind a mute box 21. Reply to the note with the quote. Check that the note appears correctly and that quoted content is behind the mute box (in the post composer view) 22. Find on Nostr a post where one of the replies contains a quoted note. Mute the user of the quoted content, and check that quoted content is now in a mute box Smoke sanity test ----------------- **PASS** **Device:** iPhone 14 pro simulator **iOS:** 16.4 **Test steps:** Browse a timeline filled with real notes and comments. Go through different notes and threads, mute some users, just to make sure nothing else appears obsviously broken. Other notes ----------- I removed this code: ``` .frame(maxWidth: .infinity, minHeight: PFP_SIZE) ``` from `EventShell`, because it was causing the layout to break on "threaded" style event view with muted quoted content (e.g. in a reply with quoted content). The line of code dates back to `495859e07f`, but I am not sure why this line existed in the first place, or if removing it has any negative impact. Closes: https://github.com/damus-io/damus/issues/1216 Changelog-Fixed: Hide quoted or reposted notes from people whom the user has muted. (#1216) Signed-off-by: Daniel D’Aquino <daniel@daquino.me> Reviewed-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com> |
||
|---|---|---|
| .. | ||
| ar.lproj | ||
| Assets.xcassets | ||
| az.lproj | ||
| bg.lproj | ||
| Components | ||
| cs.lproj | ||
| de.lproj | ||
| el-GR.lproj | ||
| en-US.lproj | ||
| en-US.xcloc | ||
| es-419.lproj | ||
| es-ES.lproj | ||
| et.lproj | ||
| fa.lproj | ||
| fi.lproj | ||
| fr.lproj | ||
| hu-HU.lproj | ||
| id.lproj | ||
| it-IT.lproj | ||
| ja.lproj | ||
| ko.lproj | ||
| lv-LV.lproj | ||
| Models | ||
| Modifiers | ||
| nl.lproj | ||
| Nostr | ||
| Notify | ||
| pl-PL.lproj | ||
| Preview Content/Preview Assets.xcassets | ||
| pt-BR.lproj | ||
| pt-PT.lproj | ||
| ru.lproj | ||
| sv-SE.lproj | ||
| sw.lproj | ||
| tr-TR.lproj | ||
| Types | ||
| uk.lproj | ||
| Util | ||
| vi.lproj | ||
| Views | ||
| zh-CN.lproj | ||
| zh-HK.lproj | ||
| zh-TW.lproj | ||
| ContentParsing.swift | ||
| ContentView.swift | ||
| damus.entitlements | ||
| damusApp.swift | ||
| Info.plist | ||
| TestData.swift | ||