mirror of
git://jb55.com/damus
synced 2024-09-16 02:03:45 +00:00
1150a144bc
This change makes the text editor/composer more robust and simple and solves Github issue #1558 It builds on the changes made for #1211, and on Jericho's (Jericho Hasselbush <jericho@sal-et-lucem.com>) discovery during his work on #1544 It uses setContentCompressionResistance, disabled text box scrolling, and dynamic height adjustments (based on more accurate layout calculations) to allow several improvements: - It ensures lines get wrapped and not overflown - It uses system native "scroll cursor into view" when typing, eliminating the need to a ghost caret - It ensures we do not have a scroll view within a scroll view (which is confusing) - It ensures that we set the height of the text box to its ideal value using a native layout calculation (Removes some issues with copying and pasting larger text) - It resolves other small issues, such as #1558 Issue #1558 repro ----------------- Result: VERIFIED Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: `476f52562a70c2615ad084640dd1a0ba5c4c12e3` Issue #1558 steps: 1. Type "hello world, hello @da" 2. Select "Damus" in contact list 3. Try moving cursor to the end of "world". Cursor should have gone there, but it immediately goes back to the end of "@damus " instead. Testing for #1558 ----------------- Result: PASS Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: This commit Steps: 1. Type "hello world, hello @da" 2. Select "Damus" in contact list 3. Try moving cursor to the end of "world". Cursor goes there. General functionality testing ----------------------------- Result: CONDITIONAL PASS. Summary: Behaviour is improved from #1211 patch, and #1558 is fixed. There are a few remaining issues, but they do not look like regressions from these changes. More details below. Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: This commit Coverage: 1. Basic typing works. PASS 2. Basic user tagging works. PASS 3. Typing long text line wraps the line. PASS 4. Adding newlines to the end of the text works and text is visible (i.e. Text box is expanding with text). PASS 5. Adding lots of newlines causes the text box and inner PostView content to expand, and those contents can be scrolled. PASS 6. Typing text when cursor is out of view (both up and down) causes PostView to scroll the cursor into view. PASS 7. Tagging user on a line positioned at the middle of the screen causes view to scroll cursor into view. PASS 8. Tagging user on a very long line positioned causes view to scroll cursor into view. PASS 9. Pasting very long text (5 paragraphs of Lorem Ipsum) expands the text box as necessary, wraps all long lines, scrolls cursor at the end into view. PASS 10. Scrolling through very long text shows that there is only one scroll view active (PostView's). PASS 11. Typing text that expands text box does not cause jitters. PASS 12. Typing mentions do not cause jitter. PASS 13. Adding newline from the end of a mid paragraph unfortunately still causes cursor to jump to the end of the text. This is an existing bug (https://github.com/damus-io/damus/issues/1521). EXISTING ISSUE. 14. Tagging a user at the end of a line when there are other lines below it may cause the cursor to jump a few characters forward. It is unclear whether this is a regression because prior to this change the cursor would get stuck at the end of the mention. But since this is a very specific edge case that might not be a regression, it might be a good idea to address this on a separate ticket. CONDITIONAL PASS 15. Could not run PostView unit tests due to various build errors on the test target. Closes: https://github.com/damus-io/damus/issues/1558 Changelog-Fixed: Fix situations where the note composer cursor gets stuck in one place after tagging a user Changelog-Fixed: Fix some note composer issues, such as when copying/pasting larger text, and make the post composer more robust. Signed-off-by: Daniel D’Aquino <daniel@daquino.me> Signed-off-by: William Casarin <jb55@jb55.com> |
||
|---|---|---|
| .github/workflows | ||
| damus | ||
| damus-c | ||
| damus.xcodeproj | ||
| damusTests | ||
| damusUITests | ||
| devtools | ||
| docs | ||
| flatbuffers | ||
| nostrdb | ||
| nostrscript | ||
| .envrc | ||
| .gitignore | ||
| .mailmap | ||
| .rgignore | ||
| CHANGELOG.md | ||
| LICENSE | ||
| Makefile | ||
| Package.swift | ||
| README.md | ||
| shell.nix | ||
| ss.png | ||
| TODO | ||
| transifex.yml | ||
damus
A twitter-like nostr client for iPhone, iPad and MacOS.
Spec Compliance
damus implements the following Nostr Implementation Possibilities
- NIP-01: Basic protocol flow
- NIP-08: Mentions
- NIP-10: Reply conventions
- NIP-12: Generic tag queries (hashtags)
Getting Started on Damus
Damus iOS
- Get the Damus app on the iOS App Store: https://apps.apple.com/ca/app/damus/id1628663131
⚙️ Settings (gear icon, top right)
- Relays: You can add more relays to send your notes to by tapping the "+".
- Find more relays to add: https://nostr.info/relays/
- Public Key (pubkey): Your public, personal address and how people can find and tag you
- Secret Key: Your private key unique to you. Never share your private key publically and share with other clients at your own risk!
- Save your keys somewhere safe
- Log out
🏠 Personal Feed (home icon, bottom navigation)
- Feed from everyone you follow
- Can post notes by tapping the blue + button
Notes (under 🏠 Personal Feed)
- Sending a Note is easy and it goes to both your 🏠 Personal and 🔍 Global Feeds
- To tag a user you must grab their pubkey:
- Search their username in the search bar at the top of the 🔍 Global Feed and click their profile
- Tap the 🔑 icon which will copy their pubkey to your clipboard
- Go back to your 🏠 Personal Feed and tap the blue + button to compose your Note
- Add @ direcly followed by the pubkey (e.g.,
@npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s)
- You can also long-press a Note to grab their User ID aka pubkey or Note ID to link directly to a Note.
- Currently you can't delete your Notes in the iOS app
- Share images by pasting the image url which you can grab from imgbb, imgur, etc. (i.e.,
https://i.ibb.co/2SHZbwm/alpha60.jpg). Currently images only load for people you follow in the 🏠 Personal Feed. Images are not automatically loaded in 🔍 Global Feed - Engaging with Notes
- 💬 Replying to a Note: Tap the chat icon underneath the note. This will show up in the users’ notifications and in your 🏠 Personal and 🔍 Global Feeds
- ♺ Reposts: Tap the repost icon which will show up in your 🏠 Personal and 🔍 Global Feeds
- ♡ Likes: Tap the heart icon. Users will not get a notification, and cannot see who liked their note (currently, web clients can see your pfp only)
- Formatting Notes (may not format as intended in other web clients)
- Italics: 1 asterisk
*italic* - Bold: 2 asterisk
**bold** - Strikethrough: 1 tildes
~strikethrough~ - Code: 1 back-tick
`code`
- Italics: 1 asterisk
💬 Encrypted DMs (chat app, bottom navigation)
- Tap the chat icon and you'll notice there's nothing to see at first. Go to a user profile and tap the 💬 chat icon next to the follow button to begin a DM
🔍 Global Feed (magnify glass, bottom navigation)
- View the Global Feed from all the relays you've added in ⚙️ Settings. Currently you can only search hashtags and user names and pubkeys
🔔 Notifications
- All your notifications except 💬 DMs
👤 Change Your Profile (PFP) and Bio
- Go to your Profile Page on Damus app
- Tap on Edit button at the top
- You will see text fields to update your information and bio
- For PFP, insert a URL containing your image (support video: https://cdn.jb55.com/vid/pfp-editor.mp4)
- Save
⚡️ Request Sats
(Sats or Satoshis are the smallest denomination of bitcoin)
Alby (browser extension)
- Get the Alby browser extension and create your Alby address [yourname]@getalby.com or connect your existing Lightning wallet
- Convert your Damus secret key from nsec to hex at https://damus.io/key then go to Settings in Alby and under the Nostr section at the bottom of the page add your private hex key. You can also generate new address in the extension
- Click the Alby extension > click Receive > enter the amount of Sats > click Get Invoice > click Copy > then paste into Damus
- Note: On Damus Web it will appear as a string of characters but on Damus iOS it will appear as a clickable image
Zeus (mobile app)
- Download Zeus app (iOS, Google, APK)
- Tap Get Started button > tap Connect a node > click on + sign (top right) > select Indhub > press Scan Lndhub QR > (from the Alby browser extension… click your account on the top left > click Manage Accounts > click 3-dot menu to right of your account and click Export Account to get a QR code then go back to Zeus app) > scan the QR Code and tap Save Node Config button
- To create an invoice tap Lightning > tap Receive > type in amount > tap Create Invoice > tap Copy Invoice > paste into a new Damus note
Contributing
Contributors welcome! Start by examining known issues: https://github.com/damus-io/damus/issues.
Mailing lists
We have a few mailing lists that anyone can join to get involved in damus development:
- dev - development discussions
- patches - code submission and review
- product - product discussions
- design - design discussions
Contributing
Privacy
Your internet protocol (IP) address is exposed to the relays you connect to, and third party media hosters (e.g. nostr.build, imgur.com, giphy.com, youtube.com etc.) that render on Damus. If you want to improve your privacy, consider utilizing a service that masks your IP address (e.g. a VPN) from trackers online.
The relay also learns which public keys you are requesting, meaning your public key will be tied to your IP address.
Translations
Translators welcome! Join the Transifex project.
All user-facing strings must have a comment in order to provide context to translators. If a SwiftUI component has a comment parameter, use that. Otherwise, wrap your string with NSLocalizedString with the comment field populated.
Awards
There may be nostr badges awarded for contributors in the future... :)
First contributors:
- @randymcmillan
- @jcarucci27
git log bot
npub1fjtdwclt9lspjy8huu3qklr7eklp5uq90u6yh8mec290pqxraccqlufnas