mirror of
git://jb55.com/damus
synced 2024-09-18 19:23:49 +00:00
768ab3e9e4
Summary ------- This fixes the issue at Github #1531 where relays with trailing slashes cannot be removed. The root cause (Identified by @fishcakeday) was that for a relay to be removed, a certain dictionary entry containing the relay url needed to be removed prior to sending the updated relay list. However those dictionary keys used `String` objects, which cannot tell that two URLs are the same with or without a trailing slash. To fix the issue, I have used a dictionary with the type `[RelayURL: RelayInfo]`, and made the necessary protocol conformance implementations for RelayURL. This way, URLs are handled with higher accuracy (e.g. Trailing slashes do not matter, URLs that resolve to the same location will match no matter what). This allows us to leverage the existing parsing and handling logic that comes with the `URL` type, instead of manually handling URL strings. Generally speaking it is preferrable to work with higher level `URL` or `RelayURL` objects than handle URLs via `String`. There is an opportunity to refactor more code, but I intentionally kept the changes to `RelayURL` limited to the functionality in this issue, because otherwise the changeset becomes very big and risky. Issue reproduction ------------------ **Device:** iPhone 14 Pro simulator **iOS:** 17.0 **Damus:** Local build from `476f52562` with the following local change: ``` diff Signed-off-by: William Casarin <jb55@jb55.com> |
||
|---|---|---|
| .. | ||
| project.xcworkspace | ||
| xcshareddata/xcschemes | ||
| project.pbxproj | ||